From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: policy discussion on bundling ELPA packages in the emacs tarball Date: Fri, 22 Jan 2021 18:50:02 -0800 Message-ID: <86tur88izp.fsf@stephe-leake.org> References: <86eeifawx8.fsf@stephe-leake.org> <87czxygdl9.fsf@russet.org.uk> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38459"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (windows-nt) Cc: emacs-devel To: Phillip Lord Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 23 03:51:08 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3912-0009tv-I4 for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 03:51:08 +0100 Original-Received: from localhost ([::1]:34718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3911-0000Rs-IE for ged-emacs-devel@m.gmane-mx.org; Fri, 22 Jan 2021 21:51:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3907-0008Lr-49 for emacs-devel@gnu.org; Fri, 22 Jan 2021 21:50:11 -0500 Original-Received: from gateway31.websitewelcome.com ([192.185.143.234]:33653) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3904-0004An-PC for emacs-devel@gnu.org; Fri, 22 Jan 2021 21:50:10 -0500 Original-Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 075E519461D for ; Fri, 22 Jan 2021 20:50:07 -0600 (CST) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with SMTP id 3902lnhmxSrGM3902lYczT; Fri, 22 Jan 2021 20:50:07 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=O0VBpjXhyBD3jod8RE9KptoPaCnW2ygOi55h//mlQJM=; b=NtDay38h3KkAN4IpLc522oz+/ 7vhycJA6fVNxNV0RrZEIA/SuonQD5b4QfcZVWtmLm/jOGRxRP06rK9y8T1tu7fpe2jIDrI42gsCPH E/O6t6TnfbfSiIkxrYWPu/KtJSP/ixgo1Mb9wRjr6jw84ObuL6bGEjLDwlCMWp/AmcEih33ayRdZs mKc4qY/FaWVPKwWHwjqK6JCOza9Dp9JNyf2NEdO83sRx9XRA1d6AxpcE6sB82muyxW/xHCMAVlwhf SoNG/R5hfzTQeSZI8MyveF8oeLbnbewHwbHcX1/diiMutAX1laKgxAtv0gWL1RGkZgS65bkNtgKAT zNnEblgHg==; Original-Received: from [76.77.182.20] (port=65220 helo=Takver4) by host2007.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l3902-003TKL-9p; Fri, 22 Jan 2021 19:50:06 -0700 In-Reply-To: <87czxygdl9.fsf@russet.org.uk> (Phillip Lord's message of "Thu, 21 Jan 2021 21:54:58 +0000") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 76.77.182.20 X-Source-L: No X-Exim-ID: 1l3902-003TKL-9p X-Source-Sender: (Takver4) [76.77.182.20]:65220 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 2 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes Received-SPF: neutral client-ip=192.185.143.234; envelope-from=stephen_leake@stephe-leake.org; helo=gateway31.websitewelcome.com X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_BL_SPAMCOP_NET=1.347, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263294 Archived-At: Phillip Lord writes: > One, both for myself and when building for Windows I use worktrees. So I have > > emacs-git/feature/native-comp > emacs-git/master > emacs-git/emacs-27 > > For personal use I build in source, for Windows building I use these for > out of source builds. > > How does that work with ELPA sub-modules? Git worktrees I think hard > links, so the files sizes are much smaller, but with submodules I am > going to get some of ELPA and it's .git multiple times? Hmm. Perusing https://git-scm.com/docs/gitsubmodules hints that the submodules could be worktrees if the "Git directory located under the $GIT_DIR/modules/" can be a worktree link, but there's no option for 'git submodule add' to specify that. Doing a web search found: https://stackoverflow.com/questions/31871888/what-goes-wrong-when-using-git-worktree-with-git-submodules which says using worktrees that contain submodules is not a good idea. and https://github.com/git/git/commit/1a248cf21d450eb911d01a89c84412c2da365e66 which is 4 years old, but indicates that mixing worktrees and submodules was an issue then. I'll have to test some stuff. If the submodules cannot be worktrees, then I think we have to abandon this approach. Although maybe using --depth=1 (or some small number) would be acceptable. > My own abortive attempt to achieve ELPA bundled packages > (https://git.savannah.gnu.org/cgit/emacs.git/log/?h=feature/core-elpa-by-copy), > solved one of these two problems -- a single ELPA git repo, but still > duplicated bundled packages in each worktree. I'll look at that. > Two, I can live with the submodule update if I have to, but this will > have to be done on each Worktree I guess. Why not add `configure > --with-elpa` > https://git.savannah.gnu.org/cgit/emacs.git/log/?h=feature/core-elpa-by-copy I'll have to look at that. But "copy" implies that the git information is lost, so you can't edit the copy and push the changes. That won't do. > Three, out of source builds would I presume include the submodule in the > main git tree, not in the out of source location? Yes; with submodules, 'make build' (out of source or in source) doesn't use git to retrieve files, just the filesystem. With the alternative "only in elpa" approach, 'make build' will have to know where the local elpa source directory is; it should still not use git to retrieve files. For building a tarball, step one is get emacs and elpa checked out to the right versions, then invoke 'make build'. -- -- Stephe