unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Restore emacs-29.1 eglot behaviour on master
@ 2024-02-18  6:36 Pedro A. Aranda
  2024-02-18 12:20 ` Dmitry Gutov
  2024-02-22 13:39 ` Eli Zaretskii
  0 siblings, 2 replies; 4+ messages in thread
From: Pedro A. Aranda @ 2024-02-18  6:36 UTC (permalink / raw)
  To: emacs-devel

Hi

I've been having massive problems with eglot on master. I understand 
evolution, being on master, etc. but this is taking too much time now 
<sigh> and some LSP implementers understand but others don't even react...

I'm mainly working with Python and LaTeX and this is my eglot config:

   (setq-default eglot-workspace-configuration
                 '(:pylsp
                   (:configurationSources ["pycodestyle"]
                    :plugins (:autopep8 (:enabled t)
                              :jedi_completion (:include_params t
                                                :eager t
                                                :fuzzy :json-false)
                              :flake8      (:enabled :json-false)
                              :pylint      (:enabled :json-false)
                              :pycodestyle (:enabled :json-false)
                              :pyflakes    (:enabled t)
                              :mccabe      (:enabled t ;; boolean: true 
(default) or false
                                            :threshold 45)))
                   :texlab
                   (:completion (:matcher "prefix"))))

What I have learnt:

On emacs-29, the section relating to the LSP that is used when on a 
specific buffer (and only that) is sent tp the LSP. And everything woks 
as expected

On emacs-30. the full configuration is sent. That confuses the LSP 
servers and they start working with the default configuration, which is 
sometimes of little help.

Could the original behaviour be (re)implemented in master, please

Thanks a ton in advance,

/Pedro A. Aranda




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Restore emacs-29.1 eglot behaviour on master
  2024-02-18  6:36 Restore emacs-29.1 eglot behaviour on master Pedro A. Aranda
@ 2024-02-18 12:20 ` Dmitry Gutov
  2024-02-22 13:39 ` Eli Zaretskii
  1 sibling, 0 replies; 4+ messages in thread
From: Dmitry Gutov @ 2024-02-18 12:20 UTC (permalink / raw)
  To: Pedro A. Aranda, emacs-devel

On 18/02/2024 08:36, Pedro A. Aranda wrote:
> On emacs-29, the section relating to the LSP that is used when on a 
> specific buffer (and only that) is sent tp the LSP. And everything woks 
> as expected
> 
> On emacs-30. the full configuration is sent. That confuses the LSP 
> servers and they start working with the default configuration, which is 
> sometimes of little help.

This seems like a good material for a bug report.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Restore emacs-29.1 eglot behaviour on master
  2024-02-18  6:36 Restore emacs-29.1 eglot behaviour on master Pedro A. Aranda
  2024-02-18 12:20 ` Dmitry Gutov
@ 2024-02-22 13:39 ` Eli Zaretskii
  2024-02-22 14:02   ` João Távora
  1 sibling, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2024-02-22 13:39 UTC (permalink / raw)
  To: Pedro A. Aranda, João Távora; +Cc: emacs-devel

> Date: Sun, 18 Feb 2024 07:36:46 +0100
> From: "Pedro A. Aranda" <paaguti@gmail.com>
> 
> Hi
> 
> I've been having massive problems with eglot on master. I understand 
> evolution, being on master, etc. but this is taking too much time now 
> <sigh> and some LSP implementers understand but others don't even react...
> 
> I'm mainly working with Python and LaTeX and this is my eglot config:
> 
>    (setq-default eglot-workspace-configuration
>                  '(:pylsp
>                    (:configurationSources ["pycodestyle"]
>                     :plugins (:autopep8 (:enabled t)
>                               :jedi_completion (:include_params t
>                                                 :eager t
>                                                 :fuzzy :json-false)
>                               :flake8      (:enabled :json-false)
>                               :pylint      (:enabled :json-false)
>                               :pycodestyle (:enabled :json-false)
>                               :pyflakes    (:enabled t)
>                               :mccabe      (:enabled t ;; boolean: true 
> (default) or false
>                                             :threshold 45)))
>                    :texlab
>                    (:completion (:matcher "prefix"))))
> 
> What I have learnt:
> 
> On emacs-29, the section relating to the LSP that is used when on a 
> specific buffer (and only that) is sent tp the LSP. And everything woks 
> as expected
> 
> On emacs-30. the full configuration is sent. That confuses the LSP 
> servers and they start working with the default configuration, which is 
> sometimes of little help.
> 
> Could the original behaviour be (re)implemented in master, please
> 
> Thanks a ton in advance,

João, any comments or suggestions?

Thanks.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Restore emacs-29.1 eglot behaviour on master
  2024-02-22 13:39 ` Eli Zaretskii
@ 2024-02-22 14:02   ` João Távora
  0 siblings, 0 replies; 4+ messages in thread
From: João Távora @ 2024-02-22 14:02 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Pedro A. Aranda, emacs-devel

On Thu, Feb 22, 2024 at 1:39 PM Eli Zaretskii <eliz@gnu.org> wrote:

> João, any comments or suggestions?

Not many.

1.Pedro seems to be using per-project configuration as user
configuration. It's best to use other methods of user configuration.
See manual.
2. exactly when or how this "sending" happens is missing. There is no
recipe, and there should probably be one.  Maybe in a bug report
following the instructions in the manual?

I'm unsubscribed from this list and away from Eglot/Emacs development
atm so I can't be of more help, sorry.

João



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-02-22 14:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-18  6:36 Restore emacs-29.1 eglot behaviour on master Pedro A. Aranda
2024-02-18 12:20 ` Dmitry Gutov
2024-02-22 13:39 ` Eli Zaretskii
2024-02-22 14:02   ` João Távora

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).