From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>, Bruno Haible <bruno@clisp.org>
Cc: Collin Funk <collin.funk1@gmail.com>,
emacs-devel@gnu.org, bug-gnulib@gnu.org
Subject: Gnulib's boot-time.c breaks the build with mingw.org's MinGW
Date: Tue, 04 Jun 2024 19:27:23 +0300 [thread overview]
Message-ID: <86tti8k710.fsf@gnu.org> (raw)
Paul imported today the latest changes from Gnulib, and that broke the
Emacs MinGW build on the master branch when mingw.org's MinGW is used:
boot-time.c:49:11: fatal error: sysinfoapi.h: No such file or directory
49 | # include <sysinfoapi.h>
| ^~~~~~~~~~~~~~
compilation terminated.
mingw.org's MinGW doesn't have the sysinfoapi.h header (unlike
MinGW64). However, that header is not really needed here because the
signature of the GetTickCount64 function, which boot-time-aux.h now
calls, is completely defined in boot-time-aux.h:
typedef ULONGLONG (WINAPI * GetTickCount64FuncType) (void);
Moreover, the Microsoft documentation, here:
https://learn.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-gettickcount64
clearly says that the header file to be included when using
GetTickCount64 is windows.h, not sysinfoapi.h directly.
So I think the Gnulib code should be amended not to include
sysinfoapi.h. For the time being I made a local change in Emacs, to
be able to build the master branch with MinGW, but I don't think it's
an Emacs-specific issue.
P.S. Paul, please from now on, and until the emacs-30 release branch
is cut, please coordinate with me any updates from Gnulib. I don't
want us to destabilize the master branch inadvertently so close to the
beginning of the release cycle. TIA.
next reply other threads:[~2024-06-04 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 16:27 Eli Zaretskii [this message]
2024-06-04 18:39 ` Gnulib's boot-time.c breaks the build with mingw.org's MinGW Collin Funk
2024-06-04 18:46 ` Eli Zaretskii
2024-06-04 19:10 ` Paul Eggert
2024-06-05 11:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86tti8k710.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=collin.funk1@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).