unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Morgan Willcock <morgan@ice9.digital>
Cc: emacs-devel@gnu.org
Subject: Re: Accidental change of behaviour for electric-layout-mode?
Date: Wed, 25 Sep 2024 18:57:46 +0300	[thread overview]
Message-ID: <86tte3bu9x.fsf@gnu.org> (raw)
In-Reply-To: <87h6a37sh0.fsf@ice9.digital> (message from Morgan Willcock on Wed, 25 Sep 2024 14:50:19 +0100)

> From: Morgan Willcock <morgan@ice9.digital>
> Cc: emacs-devel@gnu.org
> Date: Wed, 25 Sep 2024 14:50:19 +0100
> 
> Just to make sure everything works in Emacs 30, I'd rather just revert
> the accidental change than get further involved in the development of
> this feature (at least in the short term).
> 
> I've attached a patch which just reverts the change that was
> accidentally applied.  This should be all that is needed unless you
> specifically want to accommodate features which accidentally worked in
> an unreleased version of Emacs.

Actually, having the variable is better, because we have run with this
code for quite some time, and someone might rely on the unintended
feature.  So I think your original patch is better.



  reply	other threads:[~2024-09-25 15:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-23 20:58 Accidental change of behaviour for electric-layout-mode? Morgan Willcock
2024-09-24 11:23 ` Eli Zaretskii
2024-09-24 12:12   ` João Távora
2024-09-24 12:59     ` Eli Zaretskii
2024-09-24 18:59       ` Morgan Willcock
2024-09-24 19:03         ` Eli Zaretskii
2024-09-24 19:39           ` Morgan Willcock
2024-09-25 11:27             ` Eli Zaretskii
2024-09-25 13:50               ` Morgan Willcock
2024-09-25 15:57                 ` Eli Zaretskii [this message]
2024-10-03 16:22                   ` Morgan Willcock
2024-10-03 18:06                     ` Eli Zaretskii
2024-10-05 10:13                       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86tte3bu9x.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=morgan@ice9.digital \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).