From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 44fcd37a486 08/11: Add more c-ts-mode indent tests Date: Sat, 07 Dec 2024 09:49:44 +0200 Message-ID: <86ttbgj5k7.fsf@gnu.org> References: <173310542049.252624.8341603519407599366@vcs3.savannah.gnu.org> <20241202021023.5060A521787@vcs3.savannah.gnu.org> <87plm7zwqx.fsf@gmx.de> <87jzce7f6y.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11292"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael.albinus@gmx.de, emacs-devel@gnu.org, acorallo@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 07 08:50:30 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJpaA-0002l8-Je for ged-emacs-devel@m.gmane-mx.org; Sat, 07 Dec 2024 08:50:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJpZU-0004ft-M4; Sat, 07 Dec 2024 02:49:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJpZS-0004fQ-R8 for emacs-devel@gnu.org; Sat, 07 Dec 2024 02:49:46 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJpZS-00017z-70; Sat, 07 Dec 2024 02:49:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=gNeNLRI5HBUzR6qUKLMF2sjEZg+sPC2YOPIxnR/QIHI=; b=NAxnePvwF9shxq6vjOkB kcP1+ynD30dip5KowK/5OlQSifiCLuSuM35mgA1WXt6qwkivwTKcFtG9icMfi+DUo4g02wLHOloWP W/+VMZhw2dYEC7vHN5owv76Banu3oqF+kl4sZLiMfE8Fv978XQcfiqM9CpU56oeZW4kHxr/mcdbJh JjRm0skwvPvSnPdCTb7C/h+DNJRl7bLABBEYOn4CbxG1O8STj26JSnwsnOiMfLGKk/Abai2X8Ak7l Zy4X1eB9QOuu2l7Gu1wP7SrVQoG6ynmJLo9CBIX/Kzq6oaqtVQmhVGTB6zlBfPh04mJsJVyg0SlHF /mguILjIGvRCNA==; In-Reply-To: (message from Yuan Fu on Fri, 6 Dec 2024 17:04:42 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326157 Archived-At: > From: Yuan Fu > Date: Fri, 6 Dec 2024 17:04:42 -0800 > Cc: Emacs Devel , > Andrea Corallo > > > > > On Dec 5, 2024, at 11:30 PM, Yuan Fu wrote: > > > > > > > >> On Dec 4, 2024, at 11:37 PM, Michael Albinus wrote: > >> > >> Yuan Fu writes: > >> > >> Hi Yuan, > >> > >>> This is baffling. I assume the pipeline build the latest > >>> tree-sitter-c/cpp grammar right? I just updated my grammar and > >>> tree-sitter lib to the latest and the tests still pass on my > >>> machine. Is tree-sitter version also the latest? > >> > >> See test/infra/Dockerfile.emba. The emacs-tree-sitter container image is > >> created prior every run, the treesitter grammars mentioned there are > >> installed. > > > > Ah, so the image uses Debian bookworm, which AFAIK is the current stable release, so it probably doesn’t have the latest tree-sitter library. Let me try to run the pipeline with tree-sitter built from upstream. > > > > Yuan > > I didn’t run the pipeline built from upstream, but I tried running the tests locally with the tree-sitter library used in the pipeline. The pipeline uses tree-sitter provided by bookworm, which is v0.20.7, a pretty old version. And indeed, with that version of tree-sitter I can see the test failure. > > Andrea, which version of tree-sitter do you have on your test bench? > > Since tree-sitter is still relatively unstable, maybe we want to use upstream tree-sitter for the test suite? I don't think this is practical. I'd rather mark that test as expected failure or "unstable", if we cannot know the version of the tree-sitter library used for the test. Or maybe you could rewrite the test so that it works in both old and new versions of the library. (FWIW, I use 0.20.8, with the latest grammar libraries, and the test fails here as well. Due to the issues with ABI breakage in the tree-sitter library, I decided that I will upgrade only when 0.25 is released, because it also bumps the language ABI version, which we can detect in Emacs.)