From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Merging native-comp and pgtk Date: Sat, 13 Feb 2021 14:10:45 +0000 Message-ID: <86sg606ot6.fsf@gmail.com> References: <07D5E64D-DAD0-45B3-B272-627A73D7CBAE@gmail.com> <87mtwhctte.fsf@gnus.org> <459A0475-E3E7-4159-82DF-93809CCF1E24@gmail.com> <87eehng52n.fsf@gnus.org> <87mtwbye5b.fsf@gmail.com> <87czx7ycva.fsf@tcd.ie> <87eehmyalr.fsf@gmail.com> <877dneoewi.fsf@tcd.ie> <875z2yy6z7.fsf@gmail.com> <878s7twq2t.fsf@gmail.com> <84adc238-c424-bb6b-da28-c4232172da5b@gmx.at> <83wnvddtgh.fsf@gnu.org> <86k0rc2a44.fsf@gmail.com> <8335y0e272.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="557"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (windows-nt) To: emacs-devel@gnu.org Cancel-Lock: sha1:OG63EJiN04ApGq+7Rpdz4WGIE3Q= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 13 15:12:12 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lAved-000AbU-RV for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Feb 2021 15:12:11 +0100 Original-Received: from localhost ([::1]:41542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAvec-0005jQ-SE for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Feb 2021 09:12:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAvdO-0004og-8v for emacs-devel@gnu.org; Sat, 13 Feb 2021 09:10:54 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]:57104) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAvdM-0000Iz-V5 for emacs-devel@gnu.org; Sat, 13 Feb 2021 09:10:54 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1lAvdK-0009Ex-CS for emacs-devel@gnu.org; Sat, 13 Feb 2021 15:10:50 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:264623 Archived-At: On Sat 13 Feb 2021, Stefan Monnier wrote: >> We may indeed decide that good support for the MS-Windows build is not >> a prerequisite, but then we'd need someone to volunteer to fix any >> potential problems, including breaking the MS-Windows build, as result >> of the merge. IME, any breakage of that kind on master is left >> unfixed until yours truly does it. > > I think it's clear we don't want to merge of those two branches if they > introduce regressions in the "normal" case (i.e. the case where we > build without pgtk and without native-comp support). > >> If I'm unable to build the native-comp code (and Andy just said >> the --with-wide-int configuration, which is what I use, doesn't >> build), > > I suspect that his report of breakage is not that the native-comp branch > can't build at all on Windows+wide-int but that it doesn't build *if* you > enable native-comp. Yes. The problem is only when configured with both "--with-wide-int" and "--with-nativecomp". Sorry if that was not clear. AndyM