From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Handle case where `beg` and `end` are strings instead of markers Date: Fri, 29 Apr 2022 10:05:20 +0300 Organization: LINKOV.NET Message-ID: <86sfpwwerz.fsf@mail.linkov.net> References: <87k0b84tfr.fsf@occasionallycogent.com> <87h76c4ruf.fsf@occasionallycogent.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39321"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: James N. V. Cash Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 29 09:11:19 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nkKmb-000A5W-Mo for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 09:11:17 +0200 Original-Received: from localhost ([::1]:40256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkKma-0000C5-Ib for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 03:11:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkKif-0007RG-NJ for emacs-devel@gnu.org; Fri, 29 Apr 2022 03:07:14 -0400 Original-Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]:51991) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkKie-0000Dt-0u for emacs-devel@gnu.org; Fri, 29 Apr 2022 03:07:13 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 3977FC0014; Fri, 29 Apr 2022 07:07:07 +0000 (UTC) In-Reply-To: <87h76c4ruf.fsf@occasionallycogent.com> (James N. V. Cash's message of "Thu, 28 Apr 2022 21:10:32 -0400") Received-SPF: pass client-ip=2001:4b98:dc4:8::226; envelope-from=juri@linkov.net; helo=relay6-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288959 Archived-At: > Hm, while my patch does fix the error I was seeing, it makes completing > multiple items with completing-read-multiple not properly insert > subsequent completions. > > I also note that I only saw the aberrant behaviour while using functions > that used CRM, so perhaps there's a more underlying cause and/or better > place to fix this. Please describe how do you expect this should behave from a UI point of view. I see that when using on a simple call: (completing-read-multiple "Tags: " '(("tag1") ("tag2") ("tag3"))) subsequent completions can be selected properly after replacing these lines in your patch + (+ (search-forward beg) + (length beg))))) with + (search-forward beg))))