From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: outline-mode treesitter support? Date: Wed, 20 Dec 2023 09:50:13 +0200 Organization: LINKOV.NET Message-ID: <86sf3xjtfe.fsf@mail.linkov.net> References: <1D18C79B-A9D5-4ECD-A95C-33159A28E2CD@gmail.com> <86r0jit8rn.fsf@mail.linkov.net> <8C0E4C36-4323-4E1B-A7A5-25A76CE5716C@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13235"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Huan Nguyen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 20 08:57:49 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rFrSf-0003Da-1i for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Dec 2023 08:57:49 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rFrRl-0005Wa-Aj; Wed, 20 Dec 2023 02:56:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFrRk-0005WS-8H for emacs-devel@gnu.org; Wed, 20 Dec 2023 02:56:52 -0500 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFrRi-0006ot-Aj for emacs-devel@gnu.org; Wed, 20 Dec 2023 02:56:52 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 75601E0007; Wed, 20 Dec 2023 07:56:46 +0000 (UTC) In-Reply-To: <8C0E4C36-4323-4E1B-A7A5-25A76CE5716C@gmail.com> (Huan Nguyen's message of "Tue, 19 Dec 2023 19:31:11 +0100") X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=217.70.183.196; envelope-from=juri@linkov.net; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314018 Archived-At: >>> Are there any plans on making outline-mode take tree sitter nodes instead of regex? >> >> The last time this was discussed a year ago, and still no progress: >> https://lists.gnu.org/archive/html/emacs-devel/2022-12/msg01010.html >> >>> Is it possible to add that functionality or would a new mode be necessary. >> >> Yes, now this is possible to do after 'outline-search-function' >> was added in Emacs 29. So you can use it to find the next outline heading >> that corresponds to the next tree sitter node. > > ‘outline-search-function’ should be documented in C-h f outline-mode help buffer. ‘outline-mode’ is irrelevant for tree sitter. You can use tree sitter only with ‘outline-minor-mode’. OK, one way to extract treesit information for outline-minor-mode is by using ‘treesit-simple-imenu’ because outline headings should correspond to imenu entries. So I looked how to do this for example in ruby-ts-mode, but it's strange that ruby-ts-mode doesn't use ‘treesit-simple-imenu-settings’: all ts-modes use ‘treesit-simple-imenu-settings’, only ruby-ts-mode doesn't use it. This means we can't use ‘treesit-simple-imenu’ for outline headings, and need to implement a separate feature similar to ‘treesit-simple-imenu’.