From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [MPS-test] scratch/igc branch (commit: 42731228d24) crashed Date: Mon, 05 Aug 2024 21:19:51 +0300 Message-ID: <86seviq1bs.fsf@gnu.org> References: <87plqnuekc.fsf@protonmail.com> <9d5pSofW1FhcAKO7fyf_c8hAwDE8aiuiDGWFglQZI-1FwaDY3KBS5zPkKt0nKUkzs0McRm9kHq47qZjzTz0rgfde5QfLH0v0KdgUxVXI6GA=@protonmail.com> <86ttfyq2xt.fsf@gnu.org> <87h6byvoiq.fsf@protonmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1873"; mail-complaints-to="usenet@ciao.gmane.io" Cc: execvy@gmail.com, emacs-devel@gnu.org To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 05 20:20:21 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sb2Jh-0000KE-5o for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Aug 2024 20:20:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sb2JL-0006DX-6d; Mon, 05 Aug 2024 14:19:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sb2JJ-00064i-4i for emacs-devel@gnu.org; Mon, 05 Aug 2024 14:19:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sb2JI-0008LX-Qk; Mon, 05 Aug 2024 14:19:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MpCEdvB+CchXWUKnOdSSZ0g5NrP6pYDkrFVmrQ6a+Z4=; b=OiB5r27cBhlf VUF4Sbyplm5b88ezTylfF2i6Mg2dnCIpCxTgGT4xYchajOsg8kXUxstPrcYGlDzgTEiap1yTSnZC8 nnB1greKfq95SoVUoJbAmLwXXrBDw0rwByN0dzqd7l8cyY44H7n/USDCpOO/9yqDiD6Seck5G1Qti eA/jhbVfWxKfluISNkfnKvSIiCyVE2Us46FdpnLUp85Wfyh6jLmzXK4GZh4GpfOtGyecYnxOcmG3X zXirPP4I35P1VQeP6SqABR5lri1vnHxBC+dRraV4oHpKXUpFEgBrZ2NDeIvCJQAwrTsFzoMczfPc4 D/OxNS92SmuqsEP/4T8grA==; In-Reply-To: <87h6byvoiq.fsf@protonmail.com> (message from Pip Cet on Mon, 05 Aug 2024 18:00:00 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322405 Archived-At: > Date: Mon, 05 Aug 2024 18:00:00 +0000 > From: Pip Cet > Cc: execvy@gmail.com, emacs-devel@gnu.org > > "Eli Zaretskii" writes: > > > The inclusion of igc.h should be conditioned by HAVE_MPS. > > Thanks. I think we currently include igc.h unconditionally and igc.h > should start with #ifdef HAVE_MPS; but I see now that I accidentally > broke that by making enum igc_obj_type public unconditionally. > > Can you clarify whether you prefer to wrap each #include or the entire > igc.h file in #ifdef HAVE_MPS? I just did, didn't I? ;-)