From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MPS: Win64 testers? Date: Tue, 06 Aug 2024 21:32:57 +0300 Message-ID: <86sevho61y.fsf@gnu.org> References: <86h6bxq3p3.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30479"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, pipcet@protonmail.com To: Quang Kien Nguyen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 06 20:34:54 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sbP1J-0007lB-5F for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Aug 2024 20:34:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sbP0D-00039T-HT; Tue, 06 Aug 2024 14:33:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbP04-00038C-KF for emacs-devel@gnu.org; Tue, 06 Aug 2024 14:33:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbP03-0006wL-Sy; Tue, 06 Aug 2024 14:33:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qLIn4Ji0RlcjiU0j2cJ+VFSKzZlYKwlKVjAgTETMIm8=; b=quDfOcvWHE14 ItEB99AtbiTJI1RY3BXjIiKv5vMFwwYhEzjRrbET5c1ppNwOE8g0DHtjnFAYUCRpbpgiSd+MMOb2Z 4Za8XrhTF1T2dRdOlCMaSwkBEWxVF230YRcvt5DdPzB7FIjUlata+/6U7WUOCx0VzKgUDfBDcXC1+ U6CciHpv8FZryFtG2VeILfyRE6y/EgExrt/0pvljZ++09SbHcB6ZRsvmWeu9PiY2HyWCeDVu3QPl3 xvwrqVCImWEg6kNhqcHY+5k4O5jSaPJFdG9Rw6+/xM5qyYi0QwXwbEWpomWeGztOw1PTcdevqWoPn 8PCkA3+N/0EF0nu4uKxR5w==; In-Reply-To: (message from Quang Kien Nguyen on Tue, 6 Aug 2024 10:39:57 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322457 Archived-At: > From: Quang Kien Nguyen > Date: Tue, 6 Aug 2024 10:39:57 -0700 > Cc: emacs-devel@gnu.org, pipcet@protonmail.com > > > What we need next is (a) a clean patch, and (b) thorough testing that > > the standard handles are indeed not inherited by sub-processes of > > Emacs when the patch is applied. > > What should be the testing for (b)? I'm not sure I understand what you are asking. Are you asking how to test that the standard handles aren't inherited by subprocesses? > One thing I noticed when I used a version with broken stdout is that the async > compilation (native or via async package) doesn't work properly. Those errors > don't show up anymore for the patch of using SetHandleInformation. I'm not talking about testing the broken build: it's known to be broken. I'm talking about testing the fixed build: the fragile dance we do with the standard streams is there for a reason, and we need to make sure the modified code does the job as well. Btw, I still don't think I've seen the patch you are want to test, so I don't even know if it's clean and correct by itself.