unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: James Thomas <jimjoe@gmx.net>
To: emacs-devel@gnu.org
Subject: Re: Overlay boundaries and undo
Date: Sat, 09 Nov 2024 11:15:29 +0530	[thread overview]
Message-ID: <86ses1rmdi.fsf@gmx.net> (raw)
In-Reply-To: <86h68ip4uq.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 08 Nov 2024 09:22:21 +0200")

Eli Zaretskii wrote:

>> I'm trying to understand how overlay boundaries interact with undo.  The
>> reason is that I'm tracking a region of a buffer with an overlay, and
>> would like to be able to restore overlay boundaries when text deleted at
>> the overlay boundary is reinserted via undo.
>>
>> - When I delete some text in a range that includes an overlay boundary,
>>   the overlay boundary is moved.  This works as expected.  In the
>>   example below I deleted one character, ".", at the end of an overlay,
>>   and the overlay boundary moved one character to the left.
>>
>> - If I then undo, the deleted text is reinserted but the overlay
>>   boundary is not moved back to its original position.
>> ...
>
> In what version of Emacs do you see this?  The implementation of
> overlays was fundamentally changed in Emacs 29, and one of the aspects
> of that change was that overlays are not based on markers anymore.

If that's the case, undoing deletions that straddle overlay boundaries
would not restore the overlay, because the boundary position is lost.

I just tried it and it seems to be so.

--



  reply	other threads:[~2024-11-09  5:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07 22:48 Overlay boundaries and undo Karthik Chikmagalur
2024-11-08  4:23 ` James Thomas
2024-11-08  7:22 ` Eli Zaretskii
2024-11-09  5:45   ` James Thomas [this message]
2024-11-09  6:48   ` James Thomas
2024-11-09  8:14     ` Eli Zaretskii
2024-11-10  0:37   ` Karthik Chikmagalur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86ses1rmdi.fsf@gmx.net \
    --to=jimjoe@gmx.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).