From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Turning on/off tree-sitter modes Date: Tue, 03 Dec 2024 18:45:53 +0200 Message-ID: <86ser41zr2.fsf@gnu.org> References: <9cd17f8b-f88c-49f6-9024-0b6d297e18ac@gutov.dev> <867c8xsmri.fsf@gnu.org> <566ac897-ea5e-4141-bcb3-306d43c9118a@gutov.dev> <865xohrvfa.fsf@gnu.org> <86wmgwnyle.fsf@gnu.org> <178dfc7f-bc2d-4e3b-8417-a616ccc0eef3@gutov.dev> <86v7wgnxlz.fsf@gnu.org> <01d83ec8-c02b-4806-8764-38dc89a89125@gutov.dev> <86ttbzojho.fsf@gnu.org> <930f5c8e-1481-43a5-8f1d-2c13a98df74f@gutov.dev> <86r072krq5.fsf@gnu.org> <27a62624-387c-4233-b995-170270e26efd@gutov.dev> <86iks245q0.fsf@gnu.org> <86bjxt2avf.fsf@gnu.org> <86wmgg26rt.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14622"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 03 17:47:16 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tIW3O-0003a5-C8 for ged-emacs-devel@m.gmane-mx.org; Tue, 03 Dec 2024 17:47:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIW2g-0002Xy-Sn; Tue, 03 Dec 2024 11:46:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIW2a-0002XD-6R for emacs-devel@gnu.org; Tue, 03 Dec 2024 11:46:28 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIW2X-0003cN-EW; Tue, 03 Dec 2024 11:46:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DrDI/t5SFkJe8y5Y9znI4stz7RrXeQmATeBoudbINug=; b=n1F8u6QViryn W1PjECGBfe6ro7Br8H1SjoME58FUSLSdGU2zpjVfZYSXwy4XsP0rtqpUiiICrECE4m36GQ9q+hHUc tSEiMWvENdx64v6WLHcGvSRqRwc6nviaFCs0OHWr75LST3zdPa04i5voX1k0bqU0Jc5fjLjV+A6J2 Ef6K+PYbnZ2oTsJ/1h/eXiMjb33PzC9jfhxPoilCY0Kw+/Y4jPvGMbPvCvi0Vz02BD7cwsEgPd85K +zuj/sLGQ3DCFm92kI5IDGjkTOmpXY1o3tOQUBblhhsRy90h8lrKWlC3y42xnkIbQjZnhugisxwXp ddmxsudOfB+m3XtQDT9VgQ==; In-Reply-To: (message from Stefan Monnier on Tue, 03 Dec 2024 09:55:55 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325995 Archived-At: > From: Stefan Monnier > Cc: dmitry@gutov.dev, emacs-devel@gnu.org > Date: Tue, 03 Dec 2024 09:55:55 -0500 > > > I think we are mis-communicating. This thread's Subject is "Turning > > on/off tree-sitter modes", so I'm asking: what we will tell users to > > to do if they want to turn ON cmake-ts-mode? > > And the answer depends on how we fix the current breakage, but most > likely it will be "same as for other modes, except doing nothing works > as well"? > > > I didn't mean to say anything about the imaginary cmake-mode, I meant > > to point out that it doesn't exist in Emacs, so our solution to this > > cannot be based solely on major-mode-remap-defaults/alist. > > Why not? > > One way to fix the current breakage is with a patch like the one below, > after which the way to choose which CMake mode to use is the same as for > any other mode. It's possible, but I don't understand why we need to invent a mode just to use major-mode-remap-defaults/alist. That was just a means to an end, no? Why not consider cmake-ts-mode just a normal major mode, like any other FOO-mode?