From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Arash Esbati Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: done! Date: Tue, 25 Jun 2019 23:12:14 +0200 Message-ID: <86r27hpdxt.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="149150"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 25 23:13:12 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfskZ-000cfB-JM for ged-emacs-devel@m.gmane.org; Tue, 25 Jun 2019 23:13:11 +0200 Original-Received: from localhost ([::1]:35280 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfskY-0005fZ-LA for ged-emacs-devel@m.gmane.org; Tue, 25 Jun 2019 17:13:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37081) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfskJ-0005fR-2e for emacs-devel@gnu.org; Tue, 25 Jun 2019 17:12:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39171) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hfskI-0000cl-Ry; Tue, 25 Jun 2019 17:12:54 -0400 Original-Received: from p4fe3ef08.dip0.t-ipconnect.de ([79.227.239.8]:57704 helo=MUTANT) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1hfskI-0005Ov-8p; Tue, 25 Jun 2019 17:12:54 -0400 In-Reply-To: (Lars Ingebrigtsen's message of "Thu, 20 Jun 2019 14:24:17 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238145 Archived-At: --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > There's now just one Warning: line left (which is being pondered upon), > and some returning warnings from eieio about obsolete functions which > are, er, complicated to fix properly, but I think we're basically done > here. :-) Thanks for all the help with the myriad of questions from me > over the last week or so. I get this warning when building Emacs on Windows: In end of data: gnus/nnmaildir.el:1795:1:Warning: the function `unix-sync' is not known to be defined. A patch fixing it is attached. Many thanks for fixing all those warnings, Emacs builds much cleaner now! Best, Arash --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Suppress-warning-about-unix-sync-in-nnmaildir.el.patch >From cc275331b4943e03d0c1c0e5264ab09974df7308 Mon Sep 17 00:00:00 2001 From: Arash Esbati Date: Tue, 25 Jun 2019 23:05:17 +0200 Subject: [PATCH] Suppress warning about unix-sync in nnmaildir.el * nnmaildir.el (nnmaildir-request-replace-article): Check if the function `unix-sync' is bound before running it. --- lisp/gnus/nnmaildir.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/gnus/nnmaildir.el b/lisp/gnus/nnmaildir.el index ac125c905a..3becee3511 100644 --- a/lisp/gnus/nnmaildir.el +++ b/lisp/gnus/nnmaildir.el @@ -1396,7 +1396,8 @@ nnmaildir-request-replace-article (with-current-buffer buffer (write-region (point-min) (point-max) tmpfile nil 'no-message nil 'excl)) - (unix-sync) ;; no fsync :( + (when (fboundp 'unix-sync) + (unix-sync)) ;; no fsync :( (rename-file tmpfile (concat (nnmaildir--cur dir) file suffix) 'replace) t))) -- 2.22.0 --=-=-=--