From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: completing on makefile targets Date: Fri, 13 Sep 2019 17:55:51 -0700 Message-ID: <86r24jpug8.fsf@stephe-leake.org> References: <86r24l74ph.fsf@stephe-leake.org> <86muf96vqa.fsf@stephe-leake.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="124648"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (windows-nt) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 14 02:56:53 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i8wMu-000WIg-KA for ged-emacs-devel@m.gmane.org; Sat, 14 Sep 2019 02:56:53 +0200 Original-Received: from localhost ([::1]:48290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8wMs-0006BV-Tf for ged-emacs-devel@m.gmane.org; Fri, 13 Sep 2019 20:56:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45297) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8wM1-0006B6-M7 for emacs-devel@gnu.org; Fri, 13 Sep 2019 20:55:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i8wLz-0004ZU-RQ for emacs-devel@gnu.org; Fri, 13 Sep 2019 20:55:56 -0400 Original-Received: from gateway33.websitewelcome.com ([192.185.146.210]:22203) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i8wLz-0004Wa-HQ for emacs-devel@gnu.org; Fri, 13 Sep 2019 20:55:55 -0400 Original-Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 75918BBC320 for ; Fri, 13 Sep 2019 19:55:52 -0500 (CDT) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with SMTP id 8wLwiVh0N4FKp8wLwiWh1i; Fri, 13 Sep 2019 19:55:52 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:To:From:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HFyiKSN5/zrZXIHaqKZHjsFixXg1/7cqxjkrK8ve6mQ=; b=fBvQNv8JUS7VqASagfSqrLjY4 8uRGnt7a4GDhwQlBKpJp2Lv1HsHikTxpfzLPuod5+nWYHQ8e1zlSt3gIMPUJM5k/0Ko+0hahf0wKg 7l/3Z4db43xBtEMUvXqQp8SHFuEiazwZfWQQPo/wOMgcz3J325uHPH+XE1NRTMiscaVDKdmyBGsJM 5HhrGSinq5xm4oLIOSzF7V8bsaq8hNYZWLDfH4+692zLC1WxLdpnOBAb0n98B8kBN5KGx2GFQpKyC 4jwqn7csnmKzwVBtQu/yXOe4csAPfSP5YljsoC7eOqAEbeUhSMqIypOfh93qDsAw18JpJ6QmGI/m/ pphx094Rg==; Original-Received: from [76.77.182.20] (port=49601 helo=Takver4) by host2007.hostmonster.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i8wLv-003xfV-Rq for emacs-devel@gnu.org; Fri, 13 Sep 2019 18:55:51 -0600 In-Reply-To: (Stefan Monnier's message of "Thu, 12 Sep 2019 18:26:05 -0400") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 76.77.182.20 X-Source-L: No X-Exim-ID: 1i8wLv-003xfV-Rq X-Source-Sender: (Takver4) [76.77.182.20]:49601 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 1 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 192.185.146.210 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240021 Archived-At: Stefan Monnier writes: >> Yeah, but I hate making assumptions like that; the relevant Makefile >> could easily be somewhere else. > > For the general pcomplete functionality to work, it's necessary for the > minibuffer's default-directory to be the same as that where the command > will be run. So, in the pcomplete/make function you *can* presume that > the default-directory is the one where `make` will run (and hence follow > `make`s rule about how to find the appropriate makefile). Hmm. Looking at the current pcomplete/make in pcmpl-gnu.el, that's what it does. It even handles the 'make' -f option. So I could just use that function. Hmm. pcomplete-completions-at-point is already in shell-dynamic-complete-functions, so maybe that's why completion on makefile targets was working, sometimes. So now I could try to figure out why it stopped working. I've now written a completion-at-point function that also handles targets in included makefiles, which I've wanted for a long time. I'll test that for a while, then look into adding that (with a controlling option) to pcomplete/make. -- -- Stephe