From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Speed up project-kill-buffers Date: Sat, 08 May 2021 05:03:46 -0700 Message-ID: <86r1ihig9p.fsf@stephe-leake.org> References: <87mttcgnke.fsf@posteo.net> <871raoezl0.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10195"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (windows-nt) Cc: Philip Kaludercic , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 08 14:05:21 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfLhx-0002VR-61 for ged-emacs-devel@m.gmane-mx.org; Sat, 08 May 2021 14:05:21 +0200 Original-Received: from localhost ([::1]:52168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfLhw-0004Uy-9B for ged-emacs-devel@m.gmane-mx.org; Sat, 08 May 2021 08:05:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfLga-0003Ta-2K for emacs-devel@gnu.org; Sat, 08 May 2021 08:03:57 -0400 Original-Received: from gateway33.websitewelcome.com ([192.185.145.24]:11960) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfLgX-0002W6-Ol for emacs-devel@gnu.org; Sat, 08 May 2021 08:03:55 -0400 Original-Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway33.websitewelcome.com (Postfix) with ESMTP id D46A0469F91 for ; Sat, 8 May 2021 07:03:49 -0500 (CDT) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with SMTP id fLgTlQuI5ndBKfLgTlZCmJ; Sat, 08 May 2021 07:03:49 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=l49pwYs4TQ3/tJcHDSyLZEEFoCwxOda8L0Pv0SBwxIg=; b=dUKoce8XMkq+X63NARG7LrtfOJ 4Qosnb1on8DjEGb8e56gw/MrUKddpTx/aPPyGHC6+CoktT+TnSOnPFdaJzyREQJcHWfi+NzGttOCL SjsI971C2Kavdpv5uxJU2YUOU2L1XT6PKQ3L8lHLlucyfUW058b9Ii8F9SdwUNVo+yJBs0gDsul1D 84pXZBdl7wWKv5Vgd7xmm2d8ny1Z+xPlS53CeAl8bid3t0361wNrXJ7F/VjCtGyczqsaWLS1GPzrd BHcbDyZxUZ9/GKsRL02f0JrKEReFb3h/doGWDwXvQzXoQWq5ImbYfCsrutKu19EN/02KFsxNReD5/ Mb5sBJag==; Original-Received: from [76.77.182.20] (port=61522 helo=Takver4) by host2007.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lfLgT-001ijW-42; Sat, 08 May 2021 06:03:49 -0600 In-Reply-To: (Stefan Monnier's message of "Mon, 03 May 2021 09:24:20 -0400") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 76.77.182.20 X-Source-L: No X-Exim-ID: 1lfLgT-001ijW-42 X-Source-Sender: (Takver4) [76.77.182.20]:61522 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 3 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes Received-SPF: neutral client-ip=192.185.145.24; envelope-from=stephen_leake@stephe-leake.org; helo=gateway33.websitewelcome.com X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269041 Archived-At: Stefan Monnier writes: >> I didn't know about that function! Just tried it out and it seems that >> the patch below is even faster, as project-current does not have to be >> invoked for every buffer, remote or not. > > I think it might misbehave if you have projects nested in the directory > of other projects, tho. There are also projects that do not have a single root; an Emacs elisp project (which has load-path as roots), any project with dependent external libraries. You can check (member file (project-files prj)), but that's about the same as your first patch. -- -- Stephe