From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: eglot's interface for major modes Date: Sat, 08 Apr 2023 03:30:40 -0700 Message-ID: <86r0suu0mn.fsf@stephe-leake.org> References: <874jpr35eh.fsf@mailbox.org> <86v8i7tmda.fsf@stephe-leake.org> <87mt3i3ebu.fsf@mailbox.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3995"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Sebastian Poeplau Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 08 12:31:32 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pl5r1-0000oU-Ip for ged-emacs-devel@m.gmane-mx.org; Sat, 08 Apr 2023 12:31:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pl5qL-0002mI-Gt; Sat, 08 Apr 2023 06:30:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pl5qK-0002m1-2b for emacs-devel@gnu.org; Sat, 08 Apr 2023 06:30:48 -0400 Original-Received: from gproxy4-pub.mail.unifiedlayer.com ([69.89.23.142]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pl5qI-0002o2-1j for emacs-devel@gnu.org; Sat, 08 Apr 2023 06:30:47 -0400 Original-Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 3AFC810049533 for ; Sat, 8 Apr 2023 10:30:42 +0000 (UTC) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with ESMTP id l5qEp7Bi3yk8zl5qEpf6tX; Sat, 08 Apr 2023 10:30:42 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=fuoZ2H0f c=1 sm=1 tr=0 ts=64314252 a=dWLzHQi6WpdymmZIwiVdBw==:117 a=Fln8i1WyhtedwaIJAdHvmw==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=dKHAf1wccvYA:10:nop_rcvd_month_year a=vvvmwbhNdt4A:10:endurance_base64_authed_username_1 a=b3CbU_ItAAAA:8 a=NEAV23lmAAAA:8 a=JFo3Lqwoe2DkQ47kl6QA:9 a=Rv2g8BkzVjQTVhhssdqe:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xSXrecrpvnSqO2n60MBGj+8hRpbkgaFTnmsYadRlHmA=; b=djI1iDs178A2rY/ziPCs+qYZwD R4t+bygaZHGbU4+YRf9MQK8AHs91Jzn+KBi1mT511F7NUys+6YXYmemZEmIybPlWX7m/STPHM40/K fbD3D41w8eL4zeZhrypmBgf4QxCo9CAhaOoq3DybKzZIzrgzDKbpsHER639akeX9aqbgIosrzAg5j amIYZJfF0dAf2CflgCaGS8XYlC4oXlbrRuMzHc5WOr7c1f9lAvWw46r+RjkVwXI0zOyzyfATCLYfv 2K9IeUEcI1w8RbWJ6/V2QWC6BPOGzE+RzMG+nreagf2CLgszWb6Br+BlvM5hpE8pv06bHf5JGEjYG vKQES7fw==; Original-Received: from 135-180-197-170.fiber.dynamic.sonic.net ([135.180.197.170]:64940 helo=DESKTOP-G20DCG1) by host2007.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pl5qD-002SZ2-OD; Sat, 08 Apr 2023 04:30:41 -0600 In-Reply-To: <87mt3i3ebu.fsf@mailbox.org> (Sebastian Poeplau's message of "Sat, 08 Apr 2023 11:26:52 +0200") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 135.180.197.170 X-Source-L: No X-Exim-ID: 1pl5qD-002SZ2-OD X-Source-Sender: 135-180-197-170.fiber.dynamic.sonic.net (DESKTOP-G20DCG1) [135.180.197.170]:64940 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 2 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes Received-SPF: pass client-ip=69.89.23.142; envelope-from=stephen_leake@stephe-leake.org; helo=gproxy4-pub.mail.unifiedlayer.com X-Spam_score_int: 16 X-Spam_score: 1.6 X-Spam_bar: + X-Spam_report: (1.6 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305181 Archived-At: Sebastian Poeplau writes: > And then there's one more thing I'm exploring with this major mode. The > Language Server Protocol has a concept of "semantic tokens" [1] - > essentially server-provided fontification. The VS Code plugin for Ada > uses it, and I've been able to make it work in Emacs with lsp-mode. > (eglot support for semantic tokens seems to be work in progress [2].) That will be supported by ada-mode when eglot supports it. I was also working on a patch for eglot for that (https://github.com/stephe-ada-guru/eglot), but decided to work on tree-sitter first, partly because of bugs in ada_language_server, mostly because ada_language_server is not very good for indenting, because the error recovery is poor. > The approach is probably inferior to the tree-sitter support for Ada > that you and others are working on, Why do you think that? ada_language_server does some semantic analysis (mostly name resolution), so the results are more precise than a syntax parser like wisitoken or tree-sitter can provide. ada_language_server is not incremental, but it's _very_ fast, so you have to have _very_ large files to notice a delay while editing. -- -- Stephe