Re: Stipples support in MS-Windows port

[Eli Zaretskii <eliz@gnu.org>]

> From: "Elijah G." <eg642616@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Sun, 19 May 2024 16:37:07 -0600
> 
> Good news, the stipple implementation is now done, now works using
> indent-bars package and other stipples, however there are some
> issues that i want to remark
> 
> 1. Currently it only works for stipple data and not for X Bitmap files,
>    I don't know where is stored the code for using X Bitmap in stipples.

Please elaborate: what doesn't work yet with this implementation?

> 2. I had to use `w32_create_pixmap_from_bitmap_data` for make it usable,
>    but it is defined before `image_create_bitmap_from_data`, i had to
>    copy its code for use it, Is there a problem move that function
>    before `image_create_bitmap_from_data` ?

I don't understand the problem: in C there's no requirement to have a
function defined before it is used.  All you need is its prototype to
be defined before the first use.

> 3. The bitmap created using the copied code have colors inverted,
>    I fixed it setting text color to background color and bg to fg color,
>    I'm not sure how w32_create_pixmap_from_bitmap_data works, as far as
>    i could see it does some operations to the memory, something that i
>    don't think i can help so much.
> 
> After fixing 1 (and maybe 2), I will only need to format the code (and
> maybe rename XFillRectangle function) for send the final patch here.
> 
> I'm attaching the work done if you all want to test it.

Maybe I'm missing something, but where is the stipple in the attached
image?

Thanks.