From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MPS: weak hash tables Date: Sat, 06 Jul 2024 19:33:23 +0300 Message-ID: <86r0c632gc.fsf@gnu.org> References: <-plQctKgNkvp-LJ9ov2QAiXQKxd9V-hI0yz_opRGxQtbknubCjH4rH2-ymgbw_Qr1ZhB1rtlmiEW8XtuIVNr7nR_Yj20AH6WkH6kUGp68g0=@protonmail.com> <_mNcR6ailVKpYHLxgfo_tJlYGeR0AQIzQWluspYYp5_g5pIIKkHLNfFkklQQgOKNiVW8jn8NS3i2dJ7_B2Qyx9v-Dq3MQ9mP8HNL30UWsqY=@protonmail.com> <878qyf4sgm.fsf@gmail.com> <878qye3l81.fsf@gmail.com> <86ikxi4vt5.fsf@gnu.org> <871q4639z0.fsf@gmail.com> <86zfqu39k4.fsf@gnu.org> <874j921oi5.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25576"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, pipcet@protonmail.com, emacs-devel@gnu.org To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 06 18:34:22 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQ8Md-0006Mv-MT for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Jul 2024 18:34:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQ8ME-0003Pp-JP; Sat, 06 Jul 2024 12:33:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQ8MD-0003Nq-Bj for emacs-devel@gnu.org; Sat, 06 Jul 2024 12:33:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQ8MC-0008Nw-Vh; Sat, 06 Jul 2024 12:33:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wQVU6J4zs60/Y8lwIeBWhviSg0WR4sR30iUwrXXVPik=; b=bZNH/7Ktdf3y QGBQR6BWZV5882iSJ+4aFhQ24ZHwTWGBRhrZOFWvg2LNyaVQu7J2VBExYLqE6wNB+klWOiKMJeJgh u/O5ZKo4m9BOkW7+5M3KLnnDrvxfCCH7t0xRlwbZNJwc1HddoHv9Cv0J7TFzb708cABSUo9OP+D7m 4t8GiDFmYDMeW9qyaICrbuud11YcYXITvEY2+xpH0w9Cg+z83gOK7W3YfN1F0STbG56JYHQcyRRYQ Tukfd3BxEzwsSc2XWVl8WE2vqMPa6eJh3EEWpstttd9WtsThUIRItyqB776AtMxFMfv0vzx0IfgU8 +MTVUzyxqGsF6n4VNTI0tg==; In-Reply-To: <874j921oi5.fsf@gmail.com> (message from Helmut Eller on Sat, 06 Jul 2024 18:20:02 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321446 Archived-At: > From: Helmut Eller > Cc: gerd.moellmann@gmail.com, pipcet@protonmail.com, emacs-devel@gnu.org > Date: Sat, 06 Jul 2024 18:20:02 +0200 > > On Sat, Jul 06 2024, Eli Zaretskii wrote: > > >> What else could cause it in ert-test-run-tests-batch-expensive? > > > > I don't know, and I don't see why we should guess. Run that under a > > debugger with a breakpoint in balance_an_interval that shows the > > backtrace, and you will see the answer very quickly. > > Here are the flame graphs; recorded with > > perf record -g -o ../src/emacs -Q --batch -f igc--collect \ > -l lisp/emacs-lisp/ert-tests.el --eval \ > '(ert-run-tests-batch-and-exit > "ert-test-\\(parse\\|plist\\|record\\|run-tests-batch-exp\\)")' > > Both the MPS and non-MPS version compiled with -g -O2 > -fno-omit-frame-pointer. I don't see the anything very quickly. AFAIU, we call buffer-string, which then must copy the interval tree of the buffer to the interval tree of the string we create. Is that what you wanted to know and understand?