From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MPS: commit limit Date: Tue, 16 Jul 2024 18:27:24 +0300 Message-ID: <86r0btgxwj.fsf@gnu.org> References: <7PXYgVu5A8knQy6Q03cbm6FjO7s022nC0cqCRtUDhQBgA8ZrpLqmoVRgxD8moCTJpB_52ngFaJnW5JIflrzpHe09WcmbRqiHIdWQZE9kQgU=@protonmail.com> <87tth1xm4n.fsf@gmail.com> <87msmtxkpy.fsf@gmail.com> <87ed85xj67.fsf@gmail.com> <8734olxcdj.fsf@gmail.com> <87bk2xweng.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37825"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, pipcet@protonmail.com, yantar92@posteo.net, emacs-devel@gnu.org To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 16 17:28:16 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sTk6C-0009Vt-4h for ged-emacs-devel@m.gmane-mx.org; Tue, 16 Jul 2024 17:28:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sTk5U-0000td-Sb; Tue, 16 Jul 2024 11:27:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTk5S-0000tK-UL for emacs-devel@gnu.org; Tue, 16 Jul 2024 11:27:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTk5Q-0000tD-GF; Tue, 16 Jul 2024 11:27:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EMSRuZNENQJBkr8iB47RcgVwUB09LK/ZHoRqkTy3bqk=; b=g5aH7gqQ4I6P /UvHdHnANAmoUuExfDnGZAo/TFvG7wv7aSbQMfz21YCd1md4e40rwNOUTNP7Arv4a90mo1volke// mYLytaxQBZMlVwNtSBeQWwUaqjlD4pVjVlhYE3/54it0fz42sAcG4Y8bE6qwEBubKD85oygqrrb+r rc7L088VMwfo60ycc5v+hfPz3AzBDfZfAIcvxYk7eHwtG93ZwNQ3/NNhb26DPXBnsO6SV7ZlX6HZr F6FSDsjjWH94UiIpnOE/HXnMton8jJmRK/ob1Ub+RHZT+wQX4v+UWrDSRYEHpZJV0xf8MQg2Nvcgu SOPecnw8LrHWf4fv9oo89Q==; In-Reply-To: <87bk2xweng.fsf@gmail.com> (message from Helmut Eller on Tue, 16 Jul 2024 17:16:35 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321714 Archived-At: > From: Helmut Eller > Cc: Pip Cet , Ihor Radchenko , > Eli Zaretskii , emacs-devel@gnu.org > Date: Tue, 16 Jul 2024 17:16:35 +0200 > > This patch adds a igc--set-commit-limit function. It doesn't fix the > problem with the assertion. People who use the hot MPS build will > probably see a normal memory full error and probably have to quit soon > after that. The others see the failed assertion and abort immediately. > So the end result will not be much different. Is this a debugging aid? If so, please say that in the doc string. If that's not the reason, then why would we need to limit the amount of memory MPS can commit? I think we generally let Emacs use as much memory as the system is prepared to give it, no? Thanks.