Re: emacs-30 59a895ec499: ; * .gitignore: Add lisp/eshell/esh-groups.el.

Re: emacs-30 59a895ec499: ; * .gitignore: Add lisp/eshell/esh-groups.el.

[Jim Porter]

On 7/26/2024 6:55 AM, Eli Zaretskii wrote:
> branch: emacs-30
> commit 59a895ec4991beff9862029a712b22b47c5b70b3
> Author: Eli Zaretskii <eliz@gnu.org>
> Commit: Eli Zaretskii <eliz@gnu.org>
> 
>      ; * .gitignore: Add lisp/eshell/esh-groups.el.
> ---
>   .gitignore | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index eb76ff330b8..9c58e2ebfac 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -130,6 +130,7 @@ lisp/cedet/semantic/wisent/python-wy.el
>   lisp/cedet/srecode/srt-wy.el
>   lisp/cedet/semantic/grammar-wy.el
>   lisp/eshell/esh-module-loaddefs.el
> +lisp/eshell/esh-groups.el
>   lisp/finder-inf.el
>   lisp/leim/ja-dic/
>   leim/small-ja-dic-option

Just for context, I'd previously removed this line in 4c924a533340, 
since Eshell no longer generates the "esh-groups.el" file (it generates 
"esh-module-loaddefs.el"; this was part of a change to allow ordinary 
autloads in Eshell modules alongside module-specific autoloads).

I don't see any issue with leaving "esh-groups.el" in the gitignore if 
it's more convenient for switching between older branches though. Would 
a comment here be useful to indicate that at some point in the future, 
people could remove that entry?

Re: emacs-30 59a895ec499: ; * .gitignore: Add lisp/eshell/esh-groups.el.

[Eli Zaretskii]

> Date: Sun, 28 Jul 2024 10:21:30 -0700
> From: Jim Porter <jporterbugs@gmail.com>
> 
> On 7/26/2024 6:55 AM, Eli Zaretskii wrote:
> > branch: emacs-30
> > commit 59a895ec4991beff9862029a712b22b47c5b70b3
> > Author: Eli Zaretskii <eliz@gnu.org>
> > Commit: Eli Zaretskii <eliz@gnu.org>
> > 
> >      ; * .gitignore: Add lisp/eshell/esh-groups.el.
> > ---
> >   .gitignore | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/.gitignore b/.gitignore
> > index eb76ff330b8..9c58e2ebfac 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -130,6 +130,7 @@ lisp/cedet/semantic/wisent/python-wy.el
> >   lisp/cedet/srecode/srt-wy.el
> >   lisp/cedet/semantic/grammar-wy.el
> >   lisp/eshell/esh-module-loaddefs.el
> > +lisp/eshell/esh-groups.el
> >   lisp/finder-inf.el
> >   lisp/leim/ja-dic/
> >   leim/small-ja-dic-option
> 
> Just for context, I'd previously removed this line in 4c924a533340, 
> since Eshell no longer generates the "esh-groups.el" file (it generates 
> "esh-module-loaddefs.el"; this was part of a change to allow ordinary 
> autloads in Eshell modules alongside module-specific autoloads).
> 
> I don't see any issue with leaving "esh-groups.el" in the gitignore if 
> it's more convenient for switching between older branches though. Would 
> a comment here be useful to indicate that at some point in the future, 
> people could remove that entry?

Why remove it?

Re: emacs-30 59a895ec499: ; * .gitignore: Add lisp/eshell/esh-groups.el.

[Jim Porter]

On 7/28/2024 10:44 AM, Eli Zaretskii wrote:
>> Date: Sun, 28 Jul 2024 10:21:30 -0700
>> From: Jim Porter <jporterbugs@gmail.com>
>>
>> I don't see any issue with leaving "esh-groups.el" in the gitignore if
>> it's more convenient for switching between older branches though. Would
>> a comment here be useful to indicate that at some point in the future,
>> people could remove that entry?
> 
> Why remove it?

I figured if that file existed on a newer revision it would be worth 
knowing about. Maybe someone in the future would want to make a file 
named "esh-groups.el" with different content and would be confused that 
it didn't get committed (I've been bitten by this before in other 
projects, though usually with wildcards or directories).

That said, it's no real problem to keep it around either. At worst it's 
a single useless line in the gitignore.