From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 8c81818673a 6/7: Tune volatile in read_char Date: Mon, 19 Aug 2024 22:29:07 +0300 Message-ID: <86r0akwbuk.fsf@gnu.org> References: <172386820621.30556.15409337288904485218@vcs2.savannah.gnu.org> <87f24fac-aa71-499f-a398-2bad70a0ca42@cs.ucla.edu> <8634n0y2th.fsf@gnu.org> <87plq4cyuj.fsf@protonmail.com> <861q2ky0tg.fsf@gnu.org> <87le0scxig.fsf@protonmail.com> <86y14swksj.fsf@gnu.org> <871q2kcp0a.fsf@protonmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11775"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acorallo@gnu.org, eggert@cs.ucla.edu, emacs-devel@gnu.org, stefankangas@gmail.com To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 19 21:29:39 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sg84R-0002vm-H5 for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Aug 2024 21:29:39 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sg84A-0000Yw-Kc; Mon, 19 Aug 2024 15:29:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sg842-0000YM-KH for emacs-devel@gnu.org; Mon, 19 Aug 2024 15:29:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sg842-0007f5-8w; Mon, 19 Aug 2024 15:29:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jdFqEXJuanunptRW33jSMySblIjL2ykpwiCEO4Aon4g=; b=DZ9XiwgFA3Dv /jCH6xDw9h5ktm/PtAC1G4QLQFcUCLbevQe6swtzEB+Xx5G8kDrI8YvzVX+bzl+1OozfJ/Kgudxjb CkSobLpgnyPwYF7qE4h6fi6ZMhzJNUHq5LK2pD0J5kGJfJrHVb8e/82LfHZxe4XSwTBsHWAZpqsOT AoOADhTENLrewYTZ9T3T7xDgCeWod37ZoZmBYG8nBcW0q5PLyJgcejQc2TrYTed1sgu4x90oGET8j +5PWWr+ygpoEdZNcpinW6Vr/1HyvhZ6AzOCZWLBpTMAAWbGdPsxAUDJdw7OX2xDbTjQy90AD6e7ZL fRcLbV3uoVG11xZKdW6sag==; In-Reply-To: <871q2kcp0a.fsf@protonmail.com> (message from Pip Cet on Mon, 19 Aug 2024 19:05:12 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322943 Archived-At: > Date: Mon, 19 Aug 2024 19:05:12 +0000 > From: Pip Cet > Cc: acorallo@gnu.org, eggert@cs.ucla.edu, emacs-devel@gnu.org, stefankangas@gmail.com > > "Eli Zaretskii" writes: > > >> either duplicating them into a 'c_volatile' > >> / 'c' pair, as Paul's patch did, or keeping a single volatile > >> variable. I think "let's make all of them volatile" is an obvious > >> simplification of that idea. > > > > Why not simply undo that single patch, and be done? > > Because we will run into further setjmp()-related bugs. What bugs? that change is described as a minor optimization, so no bugs should be caused by reverting it.