From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Fixing compilation and byte-compilation warnings before 25.1 Date: Sat, 14 Nov 2015 15:23:27 +0000 Message-ID: <86pozcbo5s.fsf@gmail.com> References: <5645F670.9040601@online.de> <56460E2B.10603@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1447558770 15015 80.91.229.3 (15 Nov 2015 03:39:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 Nov 2015 03:39:30 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 15 04:39:20 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zxo9u-0005V8-VA for ged-emacs-devel@m.gmane.org; Sun, 15 Nov 2015 04:39:19 +0100 Original-Received: from localhost ([::1]:39592 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zxo9u-0006DQ-3p for ged-emacs-devel@m.gmane.org; Sat, 14 Nov 2015 22:39:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zxcg8-00063M-0V for emacs-devel@gnu.org; Sat, 14 Nov 2015 10:23:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zxcg5-0006iL-FE for emacs-devel@gnu.org; Sat, 14 Nov 2015 10:23:48 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:36119) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zxcg5-0006gW-8E for emacs-devel@gnu.org; Sat, 14 Nov 2015 10:23:45 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Zxcg2-0006N9-G2 for emacs-devel@gnu.org; Sat, 14 Nov 2015 16:23:42 +0100 Original-Received: from 82-69-64-228.dsl.in-addr.zen.co.uk ([82.69.64.228]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 14 Nov 2015 16:23:42 +0100 Original-Received: from andrewjmoreton by 82-69-64-228.dsl.in-addr.zen.co.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 14 Nov 2015 16:23:42 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 25 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 82-69-64-228.dsl.in-addr.zen.co.uk User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (windows-nt) Cancel-Lock: sha1:x7L4+X3fX/aljy1ulkf7IIBaJ80= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194473 Archived-At: On Fri 13 Nov 2015, daniel sutton wrote: > Hello everyone. I'm a bit new to mucking about in the internals of emacs > but wanted to help out with cleaning up some compiler and byte compiler > warnings. > > I'm building and noticing the error > minibuffer.el:1697:12 display-completion-list called with 2 arguments but > accepts only 1. > > I'm a little confused as the this function has this signature: > (defun display-completion-list (completions &optional common-substring) ...) > In fact, this is a recursive call inside of the function > display-completion-list. > > Can someone help me understand why we are getting a compiler warning about > seemingly valid usage of optional arguments? Look at the advertised-calling-convention form at the start of the function. The calling convention has changed, and the optional argument has been removed. See (info "(elisp) Declare Form"). AndyM