unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stephen Leake <stephen_leake@stephe-leake.org>
To: emacs-devel <emacs-devel@gnu.org>
Subject: Re: bad default font on Windows mingw64
Date: Mon, 22 Jul 2019 15:10:21 -0700	[thread overview]
Message-ID: <86pnm167qq.fsf@stephe-leake.org> (raw)
In-Reply-To: <83wog9q2vk.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 22 Jul 2019 22:35:11 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Stephen Leake <stephen_leake@stephe-leake.org>
>> Date: Mon, 22 Jul 2019 12:13:59 -0700
>> 
>> >   emacs -Q -xrm Emacs.fontBackend:uniscribe
>> 
>> That gives me a readable font.
>
> Then I think you should step through w32hb_encode_char in an Emacs
> invoked normally (only with -Q), and see what happens there.  I'm
> guessing it fails for some reason.

w32hb_get_font returns a non-zero pointer.

hb_font_get_nominal_glyph returns 0.

So w32hb_encode_char returns FONT_INVALID_CODE (#xFFFFFFFF).

I don't have source step for hb_font_get_nominal_glyph; apparently
that's in the mingw64 harfbuzz library.

> Are you sure your MSYS2/MinGW64 installation is up to date?

The files are mostly from Dec 2018. 'find . -name "*harfbuzz*"' finds
several files, including

./var/lib/pacman/local/mingw-w64-x86_64-harfbuzz-1.7.5-2

which seems to say I've got harfbuzz 1.7.5.

> What was the commit from which you built your previous binary, which
> did work?

I just realized there are old copies of emacs-<version>.exe in
emacs/src; very nice! However, they are not compatible with the current
*.elc, so not fully functional.

The executable that gives good fonts:

M-x version says it was built on 2019-05-23

M-x report-emacs-bug says:

Repository revision: 5424436452bc0b3d8a62a8398f92d0c2db81e22b

The first executable that fails is:

Repository revision: d590b27ee4c43ba000172b4ad15762863d78aba1

So the commit that caused this problem is somewhere between those two. I
can bisect, if needed.

-- 
-- Stephe



  reply	other threads:[~2019-07-22 22:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-22 17:02 bad default font on Windows mingw64 Stephen Leake
2019-07-22 17:43 ` Eli Zaretskii
2019-07-22 19:13   ` Stephen Leake
2019-07-22 19:35     ` Eli Zaretskii
2019-07-22 22:10       ` Stephen Leake [this message]
2019-07-22 22:58         ` Óscar Fuentes
2019-07-23  1:03           ` Stephen Leake
2019-07-23  2:37             ` Eli Zaretskii
2019-07-25 16:51               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86pnm167qq.fsf@stephe-leake.org \
    --to=stephen_leake@stephe-leake.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).