From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Warnings in mingw64 builds on master Date: Sat, 15 Aug 2020 20:39:40 +0100 Message-ID: <86pn7r7l6r.fsf@gmail.com> References: <864kp47t20.fsf@gmail.com> <83a6yvkhby.fsf@gnu.org> <86v9hj7njb.fsf@gmail.com> <83tux3ive9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31497"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (windows-nt) To: emacs-devel@gnu.org Cancel-Lock: sha1:oeYhxdmvWb3DX342cK24fAXRUxE= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 15 21:40:40 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k722i-000859-Ok for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Aug 2020 21:40:40 +0200 Original-Received: from localhost ([::1]:43100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k722h-0003fB-Pu for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Aug 2020 15:40:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40142) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7222-00038k-RZ for emacs-devel@gnu.org; Sat, 15 Aug 2020 15:39:58 -0400 Original-Received: from static.214.254.202.116.clients.your-server.de ([116.202.254.214]:44716 helo=ciao.gmane.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7221-0000s2-JB for emacs-devel@gnu.org; Sat, 15 Aug 2020 15:39:58 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1k721p-00074m-07 for emacs-devel@gnu.org; Sat, 15 Aug 2020 21:39:45 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/15 02:23:16 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: 20 X-Spam_score: 2.0 X-Spam_bar: ++ X-Spam_report: (2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253819 Archived-At: On Sat 15 Aug 2020, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Sat, 15 Aug 2020 19:48:56 +0100 >> >> >> C:/emacs/git/emacs/master/src/w32reg.c:146:1: warning: function might be >> >> candidate for attribute 'malloc' [-Wsuggest-attribute=malloc] >> >> 146 | w32_get_string_resource (void *v_rdb, const char *name, const char *class) >> >> | ^~~~~~~~~~~~~~~~~~~~~~~ >> > >> > That's just noise. There's nothing wrong with the code. >> >> Agreed. However it is better to have a clean build than to have >> pointless warnings, so the real errors stand out. > > I'd rather we removed -Wsuggest-attribute=malloc from the options we > use. Yes - I meant that removing the warning switch is preferenable (even if I did not manage to say so clearly). AndyM