From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: Warnings in mingw64 builds on master
Date: Sat, 15 Aug 2020 20:39:40 +0100 [thread overview]
Message-ID: <86pn7r7l6r.fsf@gmail.com> (raw)
In-Reply-To: 83tux3ive9.fsf@gnu.org
On Sat 15 Aug 2020, Eli Zaretskii wrote:
>> From: Andy Moreton <andrewjmoreton@gmail.com>
>> Date: Sat, 15 Aug 2020 19:48:56 +0100
>>
>> >> C:/emacs/git/emacs/master/src/w32reg.c:146:1: warning: function might be
>> >> candidate for attribute 'malloc' [-Wsuggest-attribute=malloc]
>> >> 146 | w32_get_string_resource (void *v_rdb, const char *name, const char *class)
>> >> | ^~~~~~~~~~~~~~~~~~~~~~~
>> >
>> > That's just noise. There's nothing wrong with the code.
>>
>> Agreed. However it is better to have a clean build than to have
>> pointless warnings, so the real errors stand out.
>
> I'd rather we removed -Wsuggest-attribute=malloc from the options we
> use.
Yes - I meant that removing the warning switch is preferenable (even if
I did not manage to say so clearly).
AndyM
next prev parent reply other threads:[~2020-08-15 19:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 22:37 Warnings in mingw64 builds on master Andy Moreton
2020-08-15 16:24 ` Eli Zaretskii
2020-08-15 18:48 ` Andy Moreton
2020-08-15 19:03 ` Eli Zaretskii
2020-08-15 19:39 ` Andy Moreton [this message]
2020-08-15 20:36 ` Óscar Fuentes
2020-08-16 2:31 ` Eli Zaretskii
2020-08-16 11:21 ` Andy Moreton
2020-08-16 14:44 ` Eli Zaretskii
2020-08-16 16:45 ` Óscar Fuentes
2020-08-16 17:08 ` Eli Zaretskii
2020-08-16 15:05 ` Óscar Fuentes
2020-08-15 22:34 ` Paul Eggert
2020-08-16 2:31 ` Eli Zaretskii
2020-08-16 15:25 ` Paul Eggert
2020-08-16 15:39 ` Eli Zaretskii
2020-08-17 4:21 ` Paul Eggert
2020-08-17 16:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86pn7r7l6r.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).