unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: master 1b64ed6d6a6: * lisp/misc.el (duplicate-line-final-position): New defcustom (bug#64185).
Date: Fri, 30 Jun 2023 20:51:18 +0300	[thread overview]
Message-ID: <86pm5cesnl.fsf@mail.linkov.net> (raw)
In-Reply-To: <874jmpgusm.fsf@gmx.de> (Michael Albinus's message of "Fri, 30 Jun 2023 11:32:09 +0200")

>>     * lisp/misc.el (duplicate-line-final-position): New defcustom (bug#64185).
>>
>>     * lisp/misc.el (duplicate-line): Use it.
>>
>>     * test/lisp/misc-tests.el (misc--duplicate-line): Add tests for
>>     duplicate-line-final-position.
>
> When running the tests with native compilation, there's an error:
>
>   ELC+ELN  lisp/misc-tests.elc
> In toplevel form:
> lisp/misc-tests.el:95:12: Warning: Unused lexical variable `duplicate-line-final-position'
> lisp/misc-tests.el:102:12: Warning: Unused lexical variable `duplicate-line-final-position'
>   GEN      lisp/misc-tests.log
> Running 7 tests (2023-06-29 18:20:46+0000, selector `(not (tag :unstable))')
> Mark set (rectangle mode)
>    passed  1/7  misc--duplicate-dwim (3.970630 sec)
> Test misc--duplicate-line backtrace:
>   signal(ert-test-failed (((should (equal (point) 12)) :form (equal 7
>   ert-fail(((should (equal (point) 12)) :form (equal 7 12) :value nil
>   #f(compiled-function () #<bytecode -0x4c32571230de989>)()
>   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
>   ert-run-test(#s(ert-test :name misc--duplicate-line :documentation n
>   ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable))
>   ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
>   ert-run-tests-batch((not (tag :unstable)))
>   ert-run-tests-batch-and-exit((not (tag :unstable)))
>   command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/misc-tests" "--eval"
>   command-line()
>   normal-top-level()
> Test misc--duplicate-line condition:
>     (ert-test-failed
>      ((should
>        (equal
> 	(point)
> 	12))
>       :form
>       (equal 7 12)
>       :value nil :explanation
>       (different-atoms
>        (7 "#x7" "?\7")
>        (12 "#xc" "?\f"))))
>    FAILED  2/7  misc--duplicate-line (0.000560 sec) at lisp/misc-tests.el:83
>    passed  3/7  misc-test-backward-to-word (0.000207 sec)
>    passed  4/7  misc-test-copy-from-above-command (0.000132 sec)
>    passed  5/7  misc-test-forward-to-word (0.000131 sec)
>    passed  6/7  misc-test-upcase-char (0.000114 sec)
>    passed  7/7  misc-test-zap-up-to-char (0.000278 sec)
> Ran 7 tests, 6 results as expected, 1 unexpected (2023-06-29 18:20:50+0000, 4.174909 sec)
> 1 unexpected results:
>    FAILED  misc--duplicate-line  ((should (equal (point) 12)) :form (equal 7 12) :value nil :explanation (different-atoms (7 "#x7" "?\a") (12 "#xc" "?\f")))
>
> See for example <https://emba.gnu.org/emacs/emacs/-/jobs/69705>.
>
> Running the tests w/o native compilation don't show that error.

It should go away after updating autoloads.
I did `make autoloads`, and there is no error anymore.



  reply	other threads:[~2023-06-30 17:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <168802306502.18770.6910423069706438994@vcs2.savannah.gnu.org>
     [not found] ` <20230629071745.70945C19274@vcs2.savannah.gnu.org>
2023-06-30  9:32   ` master 1b64ed6d6a6: * lisp/misc.el (duplicate-line-final-position): New defcustom (bug#64185) Michael Albinus
2023-06-30 17:51     ` Juri Linkov [this message]
2023-07-01  7:46       ` Michael Albinus
2023-07-02  8:04         ` Michael Albinus
2023-07-02  8:07           ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86pm5cesnl.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=emacs-devel@gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).