From: Eli Zaretskii <eliz@gnu.org>
To: Helmut Eller <eller.helmut@gmail.com>
Cc: gerd.moellmann@gmail.com, acorallo@gnu.org, emacs-devel@gnu.org
Subject: Re: MPS codegen
Date: Sat, 15 Jun 2024 09:11:03 +0300 [thread overview]
Message-ID: <86plsiwxag.fsf@gnu.org> (raw)
In-Reply-To: <87jzire36a.fsf@gmail.com> (message from Helmut Eller on Fri, 14 Jun 2024 21:26:37 +0200)
> From: Helmut Eller <eller.helmut@gmail.com>
> Cc: gerd.moellmann@gmail.com, acorallo@gnu.org, emacs-devel@gnu.org
> Date: Fri, 14 Jun 2024 21:26:37 +0200
>
> On Fri, Jun 14 2024, Eli Zaretskii wrote:
>
> > More generally, what exactly has been changed wrt loading from the
> > pdumper file since commit 219f7d5?
>
> The file is first loaded (mostly) as before; then all objects from the
> hot section are copied to a MPS managed region. Finally the hot section
> is discarded.
Can't we instead tell MPS not to move or manage any objects loaded
from the pdumper file? That's basically what we do now on master: any
object loaded from the pdumper file is considered immutable.
> My hypothesis is that discard_dump is the problem. The hot section
> probably contains something that isn't properly copied and
> dump_discard_mem seems to be a bit different on Windows. Why it even
> works on Linux is a mystery to me :-).
The Windows code decommits the memory region and makes it
inaccessible. By contrast, the posix_madvise method is AFAIU just an
advisory, and doesn't necessarily make the memory inaccessible.
Moreover, the Linux man page says:
In glibc, this function is implemented using madvise(2).
However, since glibc 2.6, POSIX_MADV_DONTNEED is treated as a no-
op, because the corresponding madvise(2) value, MADV_DONTNEED,
has destructive semantics.
So to do on Posix systems the same as we do on Windows, I think we
need to call madvise with MADV_DONTNEED, even if posix_madvise is
available, and also call mmap with PROT_NONE. Do you agree? If we do
that, does the GNU/Linux build still work, or does it also crash on
startup?
next prev parent reply other threads:[~2024-06-15 6:11 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 13:39 MPS: Update Gerd Möllmann
2024-06-10 16:17 ` Andrea Corallo
2024-06-10 16:26 ` Gerd Möllmann
2024-06-10 16:44 ` Gerd Möllmann
2024-06-10 20:58 ` Andrea Corallo
2024-06-11 3:12 ` Gerd Möllmann
2024-06-11 20:35 ` Helmut Eller
2024-06-12 4:45 ` Gerd Möllmann
2024-06-12 7:54 ` Eli Zaretskii
2024-06-12 8:00 ` Gerd Möllmann
2024-06-13 9:07 ` MPS codegen (was: MPS: Update) Helmut Eller
2024-06-13 12:33 ` MPS codegen Gerd Möllmann
2024-06-13 17:48 ` Helmut Eller
2024-06-13 18:24 ` Gerd Möllmann
2024-06-13 18:31 ` Gerd Möllmann
2024-06-13 18:38 ` Helmut Eller
2024-06-13 18:54 ` Gerd Möllmann
2024-06-13 19:15 ` Helmut Eller
2024-06-13 19:37 ` Gerd Möllmann
2024-06-14 6:37 ` Eli Zaretskii
2024-06-14 7:30 ` Gerd Möllmann
2024-06-14 7:56 ` Gerd Möllmann
2024-06-14 10:52 ` Eli Zaretskii
2024-06-14 10:46 ` Eli Zaretskii
2024-06-13 23:09 ` Andrea Corallo
2024-06-14 6:08 ` Gerd Möllmann
2024-06-14 7:45 ` Helmut Eller
2024-06-14 7:59 ` Gerd Möllmann
2024-06-14 8:28 ` Gerd Möllmann
2024-06-14 8:51 ` Helmut Eller
2024-06-14 11:32 ` Eli Zaretskii
2024-06-14 12:43 ` Gerd Möllmann
2024-06-14 13:04 ` Eli Zaretskii
2024-06-14 13:17 ` Gerd Möllmann
2024-06-14 13:46 ` Eli Zaretskii
2024-06-14 14:05 ` Gerd Möllmann
2024-06-14 14:33 ` Eli Zaretskii
2024-06-14 14:46 ` Gerd Möllmann
2024-06-14 16:30 ` Helmut Eller
2024-06-14 18:28 ` Eli Zaretskii
2024-06-14 19:03 ` Eli Zaretskii
2024-06-14 19:26 ` Helmut Eller
2024-06-14 19:50 ` Gerd Möllmann
2024-06-15 6:26 ` Eli Zaretskii
2024-06-15 7:10 ` Gerd Möllmann
2024-06-15 7:34 ` Eli Zaretskii
2024-06-15 8:22 ` Gerd Möllmann
2024-06-15 6:11 ` Eli Zaretskii [this message]
2024-06-15 7:25 ` Gerd Möllmann
2024-06-15 7:46 ` Eli Zaretskii
2024-06-15 8:14 ` Gerd Möllmann
2024-06-15 8:38 ` Gerd Möllmann
2024-06-15 8:44 ` Helmut Eller
2024-06-15 8:56 ` Gerd Möllmann
2024-06-15 9:07 ` Helmut Eller
2024-06-15 9:27 ` Gerd Möllmann
2024-06-15 12:33 ` Gerd Möllmann
2024-06-16 6:16 ` Gerd Möllmann
2024-06-16 7:53 ` Eli Zaretskii
2024-06-16 8:19 ` Gerd Möllmann
2024-06-16 8:40 ` Helmut Eller
2024-06-16 8:49 ` Gerd Möllmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86plsiwxag.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=acorallo@gnu.org \
--cc=eller.helmut@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=gerd.moellmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).