From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] feat: add markdown-ts-mode Date: Thu, 04 Jul 2024 08:08:48 +0300 Message-ID: <86plrtagm7.fsf@gnu.org> References: <877cgs7m4e.fsf@gmail.com> <86frvga5zc.fsf@gnu.org> <87edazgt7v.fsf@gmail.com> <87h6ftvpzz.fsf@posteo.net> <87plugzxgx.fsf@gmail.com> <87frv7qfb6.fsf@posteo.net> <8734owcxe2.fsf@gmail.com> <87cynugufj.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29841"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Rahul Martim Juliato Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 04 07:09:55 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPEjC-0007Zk-6e for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Jul 2024 07:09:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPEiB-0001c5-Q4; Thu, 04 Jul 2024 01:08:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPEiA-0001b1-Nv for emacs-devel@gnu.org; Thu, 04 Jul 2024 01:08:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPEiA-0007gM-EG; Thu, 04 Jul 2024 01:08:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OaKYcWJbTve0mpxkBlK12g3VPcnZaRGk4VgYRVb1blY=; b=pbQc5WwVOsdc 2z5s+n3oZIVUDzzMAu7iDpm6iJnlSPPSQkfcSCiFHNb8iQT7JKw9Sqy4Unlf+lt3vBnTJuyufPHaw ULGrbeVJagRjbD78RF7sm1Nrkf0Uruvbpy3ft9ISI+/LcIqIxxcerOh7meOYG40dhVMQQcWhPjuEy zEnqHZJ4F6gZlbVc3W5u5hKEnYtwm7FRZJdMjTJV0VpZUY64ghFvjFIocB7s8PaaYmRbCHv2RQ4EH Vcul3EJS1YeCqZgOVmBe01w1awZCzhfEIF0rTijH7G8Ky9ZIa6fAkPiu7LyjOUeuldRThsHokeaVt UbjqPm+Z7/mMXxmggjukpw==; In-Reply-To: <87cynugufj.fsf@gmail.com> (message from Rahul Martim Juliato on Wed, 03 Jul 2024 16:13:52 -0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321299 Archived-At: > From: Rahul Martim Juliato > Cc: emacs-devel@gnu.org > Date: Wed, 03 Jul 2024 16:13:52 -0300 > > Could you please provide your insights or suggestions on the patch? Your > feedback is crucial for moving this forward. Thanks, please find some comments below. > * lisp/textmodes/markdown-ts-mode.el: New file > * doc/emacs/emacs.texi: Add Markdown to the manual > * etc/NEWS: Announce markdown-ts-mode Each entry should end with a period. > index 7d77f13ab21..244c822ee04 100644 > --- a/doc/emacs/emacs.texi > +++ b/doc/emacs/emacs.texi > @@ -618,6 +618,7 @@ Top > * Enriched Text:: Editing text enriched with fonts, colors, etc. > * Text Based Tables:: Commands for editing text-based tables. > * Two-Column:: Splitting text columns into separate windows. > +* Markdown:: Major mode for editing Markdown files. Where's the actual text of this new section? Looks like some part(s) of the patch were left out? > +(if (treesit-ready-p 'markdown) > + (add-to-list 'auto-mode-alist '("\\.md\\'" . markdown-ts-mode))) Should this also test that the markdown-inline grammar is present?