From: Eli Zaretskii <eliz@gnu.org>
To: Rahul Martim Juliato <rahuljuliato@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] feat: add markdown-ts-mode
Date: Thu, 04 Jul 2024 08:08:48 +0300 [thread overview]
Message-ID: <86plrtagm7.fsf@gnu.org> (raw)
In-Reply-To: <87cynugufj.fsf@gmail.com> (message from Rahul Martim Juliato on Wed, 03 Jul 2024 16:13:52 -0300)
> From: Rahul Martim Juliato <rahuljuliato@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Wed, 03 Jul 2024 16:13:52 -0300
>
> Could you please provide your insights or suggestions on the patch? Your
> feedback is crucial for moving this forward.
Thanks, please find some comments below.
> * lisp/textmodes/markdown-ts-mode.el: New file
> * doc/emacs/emacs.texi: Add Markdown to the manual
> * etc/NEWS: Announce markdown-ts-mode
Each entry should end with a period.
> index 7d77f13ab21..244c822ee04 100644
> --- a/doc/emacs/emacs.texi
> +++ b/doc/emacs/emacs.texi
> @@ -618,6 +618,7 @@ Top
> * Enriched Text:: Editing text enriched with fonts, colors, etc.
> * Text Based Tables:: Commands for editing text-based tables.
> * Two-Column:: Splitting text columns into separate windows.
> +* Markdown:: Major mode for editing Markdown files.
Where's the actual text of this new section? Looks like some part(s)
of the patch were left out?
> +(if (treesit-ready-p 'markdown)
> + (add-to-list 'auto-mode-alist '("\\.md\\'" . markdown-ts-mode)))
Should this also test that the markdown-inline grammar is present?
prev parent reply other threads:[~2024-07-04 5:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 3:23 [PATCH] feat: add markdown-ts-mode Rahul Martim Juliato
2024-04-20 6:44 ` Eli Zaretskii
2024-04-20 17:45 ` Jostein Kjønigsen
2024-04-21 5:50 ` Rahul Martim Juliato
2024-04-22 7:02 ` Philip Kaludercic
2024-04-23 1:20 ` Rahul Martim Juliato
2024-04-27 10:18 ` Philip Kaludercic
2024-06-29 2:09 ` Rahul Martim Juliato
2024-07-03 19:13 ` Rahul Martim Juliato
2024-07-03 20:13 ` Stefan Kangas
2024-07-04 5:17 ` Eli Zaretskii
2024-07-04 6:23 ` Eli Zaretskii
2024-07-04 13:19 ` Andrea Corallo
2024-07-26 3:59 ` Rahul Martim Juliato
2024-07-26 22:51 ` Stefan Kangas
2024-07-04 5:08 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86plrtagm7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rahuljuliato@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).