From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: MPS: commit limit
Date: Tue, 16 Jul 2024 18:32:05 +0300
Message-ID: <86plrdgxoq.fsf@gnu.org>
References: <m2wmm4hm9y.fsf@pro2.fritz.box> <m2wmlxd078.fsf@pro2.fritz.box>
 <oHhpNWmD2xcH4Ryp7Bxc4_wJ5XMvjDYZDKeNk3nfEFSJBUoXukJK4Lc3t-PY7f1prHjPg3QEPzSVbwcZ9qq_DTubql_85POFqQzG-xog-dc=@protonmail.com>
 <m2jzhxcu3y.fsf@pro2.fritz.box> <m2frslctjg.fsf@pro2.fritz.box>
 <7PXYgVu5A8knQy6Q03cbm6FjO7s022nC0cqCRtUDhQBgA8ZrpLqmoVRgxD8moCTJpB_52ngFaJnW5JIflrzpHe09WcmbRqiHIdWQZE9kQgU=@protonmail.com>
 <87tth1xm4n.fsf@gmail.com> <m2bk39b481.fsf@pro2.fritz.box>
 <87msmtxkpy.fsf@gmail.com>
 <DaaIWwjgQ8EpsTMAhH6XSzEqbMeQoV4PKY4mTf4NSYg4ThixwFY1SdJ0-r5dwBgt1MnhGMRyKWQTaIngAeTFIs8DJzbE2-AulFSwkyZXx4A=@protonmail.com>
 <87ed85xj67.fsf@gmail.com> <m234olb0ct.fsf@pro2.fritz.box>
 <m2ikxh9hai.fsf@pro2.fritz.box> <8734olxcdj.fsf@gmail.com>
 <m2ed859gda.fsf@pro2.fritz.box> <m2wmlw8cyv.fsf_-_@pro2.fritz.box>
 <87bk2xweng.fsf@gmail.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="21877"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: gerd.moellmann@gmail.com, pipcet@protonmail.com,
 yantar92@posteo.net, emacs-devel@gnu.org
To: Helmut Eller <eller.helmut@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 16 17:32:56 2024
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1sTkAi-0005V6-Hs
	for ged-emacs-devel@m.gmane-mx.org; Tue, 16 Jul 2024 17:32:56 +0200
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces@gnu.org>)
	id 1sTkA8-0002P9-8e; Tue, 16 Jul 2024 11:32:20 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1sTkA6-0002Ow-NA
 for emacs-devel@gnu.org; Tue, 16 Jul 2024 11:32:18 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1sTkA5-0001eT-Gf; Tue, 16 Jul 2024 11:32:18 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=kCmv9+yJAnVEEe2jJ6QoOz0S75B7mvm5lTI58kOjThs=; b=q5R0oBt0OQB3
 +LEUxz+kfYlzsocSUMpbPDZrFAoJD4YHvn5PWdcKfUmycsKXMk6AwhrWciWSlUZcSzyGBlNFIfxNM
 bbuqKRrVqKgHRqWxVGUkX2QwK7lC3lw2HKZKAa5jioZ07rK6c5U4X5jJKAuVQvD9S/3O5WZ3TCR+T
 1u1iKqrYIm07fwBhQNpOWf013e37wxTLiwkyK8GW5ltDnExGRqtWj6LqMXoj+9wXxnGLuGuTWeeO9
 b7PB6/SUIZ4fNsbaWoKSPWsXuJTzw7oG9iyN68Qr18H46BK0a+G1+ijsFzfzPTSpi/D2cfxS+bZGq
 3fWnsV7MU2ZmV5VNLvZKAg==;
In-Reply-To: <87bk2xweng.fsf@gmail.com> (message from Helmut Eller on Tue, 16
 Jul 2024 17:16:35 +0200)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.devel:321715
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/321715>

> From: Helmut Eller <eller.helmut@gmail.com>
> Cc: Pip Cet <pipcet@protonmail.com>,  Ihor Radchenko <yantar92@posteo.net>,
>   Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
> Date: Tue, 16 Jul 2024 17:16:35 +0200
> 
> +(ert-deftest set-commit-limit-test ()
> +  (should (equal (igc--set-commit-limit (ash 1 30)) nil))
> +  (should (equal (assoc-string "commit-limit" (igc-info))
> +                 '("commit-limit" 1 1073741824 0)))

Does this work in 32-bit builds?  The number 1073741824 overflows
fixnums in such a build.

> +  (should-error (igc--set-commit-limit -1)
> +                :type 'args-out-of-range)
> +  (should-error (igc--set-commit-limit (- (ash 1 64) 1))
                                             ^^^^^^^^^^
As does this.