From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Reconsider defaults for use-package-vc-prefer-newest Date: Sat, 21 Sep 2024 18:18:43 +0300 Message-ID: <86plox2fxo.fsf@gnu.org> References: <87wmj7dftf.fsf@posteo.net> <87setvxyt6.fsf@gmail.com> <87jzf7o13b.fsf@posteo.net> <87frpvo06a.fsf@posteo.net> <86y13m7swd.fsf@gnu.org> <87bk0inyr1.fsf@posteo.net> <86zfo25nxf.fsf@gnu.org> <87o74im4y8.fsf@posteo.net> <86jzf55vhv.fsf@gnu.org> <87y13lhydi.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18195"; mail-complaints-to="usenet@ciao.gmane.io" Cc: suhailsingh247@gmail.com, meedstrom@runbox.eu, emacs-devel@gnu.org, tonyzorman@mailbox.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 21 17:19:34 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ss1tV-0004YI-HX for ged-emacs-devel@m.gmane-mx.org; Sat, 21 Sep 2024 17:19:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ss1st-0005lX-IF; Sat, 21 Sep 2024 11:18:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ss1so-0005lG-TD for emacs-devel@gnu.org; Sat, 21 Sep 2024 11:18:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ss1sl-0003kO-DI; Sat, 21 Sep 2024 11:18:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ngfg6KzqMCgapvYa5XCeHyXu3UNg7Kudl3tb09cr2kU=; b=Ui02OgWvSCRR 1+i1USXGSBGTvZmjUQt24WAE8//qyZZM2jQrb1pRU5N9Ip7Ve/3AojFfOhg3d/NofACB5fKwbK1Ha /a8pmmu6qUMThxqrG7gswWvfyW99soMaFDzP468MmSCsvrh8GvO3UtIx5Q3cy/FwjoefnDer6Wr5z T/Ug3d5xjFeKcwh6nbjiOqmKipPv9rsy33UdoGJhdFu6vZqw9nXICRGeA6tYMAD5T7F3oZVIXi96+ ga23DWrBImRuCrT8rxGTA2bUJhmqB8pdZP2AuK3WpEZ5YQjmoZa6lMZvAkKjrAz4HfXwPfvE86hxr II+8KFBnfV1WFTjIDt9P7Q==; In-Reply-To: <87y13lhydi.fsf@posteo.net> (message from Philip Kaludercic on Sat, 21 Sep 2024 14:31:21 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323896 Archived-At: > From: Philip Kaludercic > Cc: suhailsingh247@gmail.com, meedstrom@runbox.eu, emacs-devel@gnu.org, > tonyzorman@mailbox.org > Date: Sat, 21 Sep 2024 14:31:21 +0000 > > Eli Zaretskii writes: > > >> From: Philip Kaludercic > >> Cc: suhailsingh247@gmail.com, meedstrom@runbox.eu, emacs-devel@gnu.org, > >> tonyzorman@mailbox.org > >> Date: Fri, 20 Sep 2024 20:43:27 +0000 > >> > >> Eli Zaretskii writes: > >> > >> >> From: Philip Kaludercic > >> >> Cc: suhailsingh247@gmail.com, meedstrom@runbox.eu, emacs-devel@gnu.org, > >> >> tonyzorman@mailbox.org > >> >> Date: Fri, 20 Sep 2024 15:14:26 +0000 > >> >> > >> >> Eli Zaretskii writes: > >> >> > >> >> >> This is the fix: > >> >> > > >> >> > Can you explain in plain English what this does? > >> >> > >> >> Sure, each package has a description object (search for "(cl-defstruct > >> >> (package-desc" in package.el), with some fixed attributes like name, > >> >> version, dependencies and others that are stored in an alist. The > >> >> commit used to create a package is one such attribute stored in the > >> >> "extras" slot of a package-desc. My chance modifies the package > >> >> description given by the ELPA server and updates the :commit field to > >> >> store the commit that was checked out when the package was built > >> >> locally. I hope that is clear enough? > >> > > >> > Yes, thanks. What was the :commit field storing before the change? > >> > >> The commit the ELPA build server used to release a new version of the > >> package. > > > > That is not right, I agree. > > > >> M-x list-packages lists the commit of the local checkout for > >> VC packages, btw. > > > > What is "the local checkout" in this context? > > The checkout of the VC package that the *Help* buffer is describing. > > >> I could have sworn that M-x describe-package did the same. > > > > Shouldn't they all be consistent in what commit they show? > > Yes, that is my point. But since the commit in the package description > is not updated when the package is installed, there is a discrepancy. So your change should make all of them agree? In that case, please install, and thanks.