From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 44c7b49: In xref-collect-references, force backends to respect the 'dir' arg Date: Thu, 28 Jan 2016 04:15:32 -0600 Message-ID: <86oac680xn.fsf@stephe-leake.org> References: <20160122075954.10103.93473@vcs.savannah.gnu.org> <56A96C3F.6050107@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1453976316 28711 80.91.229.3 (28 Jan 2016 10:18:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Jan 2016 10:18:36 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 28 11:18:24 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aOjeg-0004VW-L3 for ged-emacs-devel@m.gmane.org; Thu, 28 Jan 2016 11:18:22 +0100 Original-Received: from localhost ([::1]:55084 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOjeg-0004qb-26 for ged-emacs-devel@m.gmane.org; Thu, 28 Jan 2016 05:18:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42626) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOjc8-00085k-RQ for emacs-devel@gnu.org; Thu, 28 Jan 2016 05:15:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOjc5-0001hH-DW for emacs-devel@gnu.org; Thu, 28 Jan 2016 05:15:44 -0500 Original-Received: from gproxy9-pub.mail.unifiedlayer.com ([69.89.20.122]:53534) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1aOjc5-0001h2-6k for emacs-devel@gnu.org; Thu, 28 Jan 2016 05:15:41 -0500 Original-Received: (qmail 17760 invoked by uid 0); 28 Jan 2016 10:15:38 -0000 Original-Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy9.mail.unifiedlayer.com with SMTP; 28 Jan 2016 10:15:38 -0000 Original-Received: from host114.hostmonster.com ([74.220.207.114]) by cmgw4 with id BNFZ1s00Y2UdiVW01NFcms; Thu, 28 Jan 2016 03:15:38 -0700 X-Authority-Analysis: v=2.1 cv=IekUBwaa c=1 sm=1 tr=0 a=CQdxDb2CKd3SRg4I0/XZPQ==:117 a=CQdxDb2CKd3SRg4I0/XZPQ==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=hEr_IkYJT6EA:10 a=x_XPkuGwIRMA:10 a=7aQ_Q-yQQ-AA:10 a=vaJtXVxTAAAA:8 a=9i_RQKNPAAAA:8 a=52mAfuoi_jpiqiYhm3UA:9 Original-Received: from [76.218.37.33] (port=64134 helo=TAKVER3) by host114.hostmonster.com with esmtpa (Exim 4.84) (envelope-from ) id 1aOjbx-00047d-HC; Thu, 28 Jan 2016 03:15:33 -0700 In-Reply-To: <56A96C3F.6050107@yandex.ru> (Dmitry Gutov's message of "Thu, 28 Jan 2016 04:17:51 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (windows-nt) X-Identified-User: {2442:host114.hostmonster.com:stephele:stephe-leake.org} {sentby:smtp auth 76.218.37.33 authed with stephen_leake@stephe-leake.org} X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 69.89.20.122 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198939 Archived-At: Dmitry Gutov writes: > On 01/22/2016 10:59 AM, Stephen Leake wrote: >> branch: emacs-25 >> commit 44c7b49d9a8188e8befc85f7e95d074ad4605c6a >> Author: Stephen Leake >> Commit: Stephen Leake >> >> In xref-collect-references, force backends to respect the 'dir' arg >> >> * lisp/progmodes/xref.el (xref-collect-references): Force symref backends >> to use `default-directory'. > > Does this change work fine for you? Yes. > The byte compiler complains that ede-minor-mode is an "unused lexical > variable", so I expect there may be a problem with byte-compiled code. The `let' either binds the existing global variable, or creates a new local one; no problems. > It there _is_ a problem, (defvar ede-minor-mode) should help. I left that out by mistake. -- -- Stephe