* Re: [Emacs-diffs] master 2be537e: Minor updates to project.el
[not found] ` <20190519172903.67D3520496@vcs0.savannah.gnu.org>
@ 2019-05-20 6:18 ` Dmitry Gutov
2019-05-20 8:23 ` Stephen Leake
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Gutov @ 2019-05-20 6:18 UTC (permalink / raw)
To: emacs-devel, Stephen Leake
On 19.05.2019 20:29, Stephen Leake wrote:
> branch: master
> commit 2be537e6433b9b2a8d9dcb9c23493755d35d6ecc
> Author: Stephen Leake <stephen_leake@stephe-leake.org>
> Commit: Stephen Leake <stephen_leake@stephe-leake.org>
>
> Minor updates to project.el
>
> * lisp/progmodes/project.el (project-find-file): Add optional 'filename' arg.
Sorry, but why?
If this is for Lisp programs, can't you just call project-find-file-in?
If you really need this, I think the argument should have a different
name (it's not a file name, it's initial-input), and it needs to be
documented.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Emacs-diffs] master 2be537e: Minor updates to project.el
2019-05-20 6:18 ` [Emacs-diffs] master 2be537e: Minor updates to project.el Dmitry Gutov
@ 2019-05-20 8:23 ` Stephen Leake
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Leake @ 2019-05-20 8:23 UTC (permalink / raw)
To: emacs-devel
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 19.05.2019 20:29, Stephen Leake wrote:
>> branch: master
>> commit 2be537e6433b9b2a8d9dcb9c23493755d35d6ecc
>> Author: Stephen Leake <stephen_leake@stephe-leake.org>
>> Commit: Stephen Leake <stephen_leake@stephe-leake.org>
>>
>> Minor updates to project.el
>> * lisp/progmodes/project.el (project-find-file): Add
>> optional 'filename' arg.
>
> Sorry, but why?
The use case is that some lisp code has a non-directory filename and
wants to find it in a project.
> If this is for Lisp programs, can't you just call
> project-find-file-in?
Yes, that makes sense.
I'll revert that part of the commit.
--
-- Stephe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-20 8:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190519172901.5122.23242@vcs0.savannah.gnu.org>
[not found] ` <20190519172903.67D3520496@vcs0.savannah.gnu.org>
2019-05-20 6:18 ` [Emacs-diffs] master 2be537e: Minor updates to project.el Dmitry Gutov
2019-05-20 8:23 ` Stephen Leake
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).