unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stephen Leake <stephen_leake@stephe-leake.org>
To: emacs-devel <emacs-devel@gnu.org>
Subject: Re: limit length of xref file header line
Date: Fri, 24 May 2019 14:38:14 -0800	[thread overview]
Message-ID: <86o93rv5pl.fsf@stephe-leake.org> (raw)
In-Reply-To: <db0c7ef0-4544-1948-1425-600c813be99e@yandex.ru> (Dmitry Gutov's message of "Tue, 21 May 2019 04:16:20 +0300")

Dmitry Gutov <dgutov@yandex.ru> writes:

>> So I'd like to shorten the filename line (called the "group" in xref).
>
> This is not exactly right. The group attribute can contain the
> filename, but it doesn't have to. Or else we'd have called in
> differently.
>
> BTW, check out the three definitions of
>
>   (cl-defmethod xref-location-group ...
>
> for the built-in classes.

Right; I did not look hard enough.

>> The patch below adds a new user option 'xref-display-filename' to
>> control this.
>
> ... the appropriate place to change
> the "display" would instead be in
>
>   (cl-defmethod xref-location-group ((l xref-file-location))
>     (oref l file))

So:

(cl-defmethod xref-location-group ((l xref-file-location))
  (cl-ecase xref-file-name-display
    (abs (oref l file))
    (nondirectory (file-name-nondirectory (oref l file)))))

-- 
-- Stephe



  parent reply	other threads:[~2019-05-24 22:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-19 17:57 limit length of xref file header line Stephen Leake
2019-05-21  1:16 ` Dmitry Gutov
2019-05-21  9:47   ` Dmitry Gutov
2019-05-24 22:38   ` Stephen Leake [this message]
2019-05-25 21:22     ` Dmitry Gutov
2021-09-12 22:47       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86o93rv5pl.fsf@stephe-leake.org \
    --to=stephen_leake@stephe-leake.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).