From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Select completions from the minibuffer Date: Tue, 22 Mar 2022 19:52:13 +0200 Organization: LINKOV.NET Message-ID: <86o81x6fjm.fsf@mail.linkov.net> References: <87v8wl35wg.fsf@gnus.org> <86k0d06dik.fsf@mail.linkov.net> <87ee3714li.fsf@gnus.org> <86r1773sb4.fsf@mail.linkov.net> <87pmmquew4.fsf@gnus.org> <86h7817mj4.fsf@mail.linkov.net> <87ilsgx5fx.fsf@gnus.org> <86bkxz3y1h.fsf@mail.linkov.net> <875yo7p0hh.fsf@gnus.org> <86v8w675un.fsf@mail.linkov.net> <20220322172310.f22uq4bzxrfzrqhm@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24543"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 22 18:57:54 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWilV-0006B6-2k for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Mar 2022 18:57:53 +0100 Original-Received: from localhost ([::1]:50150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWilT-0003S6-Je for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Mar 2022 13:57:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWikY-0002h9-4F for emacs-devel@gnu.org; Tue, 22 Mar 2022 13:56:54 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:59871) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWikW-0001BE-5P for emacs-devel@gnu.org; Tue, 22 Mar 2022 13:56:53 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 3D10B60008; Tue, 22 Mar 2022 17:56:46 +0000 (UTC) In-Reply-To: <20220322172310.f22uq4bzxrfzrqhm@Ergus> (Ergus's message of "Tue, 22 Mar 2022 18:23:10 +0100") Received-SPF: pass client-ip=217.70.183.195; envelope-from=juri@linkov.net; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287365 Archived-At: > I see that setting cursor-face-highlight-nonselected-window to t by > default produces a highlight a bit annoying for some users... > > So I think that we may disable it and problem solved. > > For your selection from minibuffer I am not sure how you plan to enable > it, but I suppose you will make a minor mode, so instead of setq-local > on every call probably you will prefer to do something like: > > (defun minibuffer-select-completion-setup-function () > (with-current-buffer standard-output > (when completions-highlight-face > (setq-local cursor-face-highlight-nonselected-window t)))) > > (add-hook 'completion-setup-hook #'minibuffer-select-completion-setup-function) > > Is it fine for you? Actually, such highlighting in non-selected completions window is needed only for new commands that use the new macro with-minibuffer-completions-window, because this macro navigates completions in the non-selected window, so this works fine: ``` (defun minibuffer-previous-completion (&optional n) "Run `previous-completion' from the minibuffer in its completions window." (interactive "p") (with-minibuffer-completions-window (let ((completion-wrap-movement nil)) (setq-local cursor-face-highlight-nonselected-window t) (previous-completion n)))) ```