From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: Other details about completion. Date: Wed, 06 Apr 2022 21:34:12 +0300 Organization: LINKOV.NET Message-ID: <86o81eawnv.fsf@mail.linkov.net> References: <86r16g92v5.fsf@mail.linkov.net> <20220401202425.jfrwqmkm3ffmcm5h@Ergus> <20220404193501.adojhz7uvvaoq4sj@Ergus> <86czhw4oqr.fsf@mail.linkov.net> <4E8D9AEF-4D7A-4B11-822F-8D0911964A05@aol.com> <86bkxfibdo.fsf@mail.linkov.net> <20220405232013.5y5jnr4ykzqgxqla@Ergus> <86a6cyiqlt.fsf@mail.linkov.net> <20220406132108.evlofp5l3krsl5h7@Ergus> <86sfqqduon.fsf@mail.linkov.net> <20220406181339.iubahj6fviq3fyqv@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5379"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Philip Kaludercic , emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 06 20:38:01 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncAXZ-0001Fo-EY for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Apr 2022 20:38:01 +0200 Original-Received: from localhost ([::1]:37048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ncAXY-0007xs-Aj for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Apr 2022 14:38:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncAVH-00059h-55 for emacs-devel@gnu.org; Wed, 06 Apr 2022 14:35:40 -0400 Original-Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]:53651) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncAVD-0007PK-Mv for emacs-devel@gnu.org; Wed, 06 Apr 2022 14:35:38 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 6E4D6E0006; Wed, 6 Apr 2022 18:35:31 +0000 (UTC) In-Reply-To: <20220406181339.iubahj6fviq3fyqv@Ergus> (Ergus's message of "Wed, 6 Apr 2022 20:13:39 +0200") Received-SPF: pass client-ip=2001:4b98:dc4:8::224; envelope-from=juri@linkov.net; helo=relay4-d.mail.gandi.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287852 Archived-At: >>Here is the next patch that does this and allows using all arrow keys >>only when the completions window is visible: > > Ok quick check :) > > With the new option the behavior gives a much better navigation. > > 1) There is still the issue with C-g or ESC canceling everything Do you mean addition step is needed where first C-g/ESC will clear the suffix, then another C-g/ESC will exit the minibuffer? > 2) In tabular navigation the down arrow always goes to the first column > which is wrong; maybe it should use next-line or line-move instead of > forward-line? This is what I tried first, but byte-compiler complained next-line is only for interactive use. > 3) It still needs and extra binding to insert and then to another > execute... RET just removes the highlight and nothing else... which is > un-intuitive because the candidate in principle is already selected. Then it should always insert the selected candidate. > I am not a good lisper, but I think that an approach with a minor mode > or a transient-map could end up being simpler and more modular without > adding more complexity in the existing code... WDYT? A minor mode that adds a hook to minibuffer-setup-hook that activates another mode with additional keymap? Looks more complex. And a transient-map on post-command-hook is even more complicated.