From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Tue, 30 Aug 2022 19:47:35 +0300 Organization: LINKOV.NET Message-ID: <86o7w1zniw.fsf@mail.linkov.net> References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <83bks3vtf5.fsf@gnu.org> <83tu5uug68.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22348"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , larsi@gnus.org, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 30 19:07:25 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT4hw-0005dy-QU for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 19:07:24 +0200 Original-Received: from localhost ([::1]:47836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oT4hv-0002tK-P2 for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 13:07:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58644) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT4XI-00010G-6P for emacs-devel@gnu.org; Tue, 30 Aug 2022 12:56:25 -0400 Original-Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]:34987) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT4XF-0000Xi-Nt; Tue, 30 Aug 2022 12:56:23 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id A5058FF804; Tue, 30 Aug 2022 16:56:14 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Tue, 30 Aug 2022 15:35:31 +0300") Received-SPF: pass client-ip=2001:4b98:dc4:8::229; envelope-from=juri@linkov.net; helo=relay9-d.mail.gandi.net X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, GAPPY_SUBJECT=0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294363 Archived-At: >> But even if we initially only support this in otherwise clean trees, >> it will be a huge advantage vs the current situation, where this >> feature is simply not available. > > Will the advantage be significant? I really have to ask, because IME > applying an external patch and them committing the files as a whole never > felt particularly painful before (aside from resolving any conflicts or > corrupted whitespace, which the new feature doesn't help with). Indeed, just 'M-! git apply' before using 'vc-checkin-patch' will do the job in case of an external patch. > And 'diff-mode' has had the 'diff-apply-hunk' command for ages -- > I use it often. > > OTOH, the lack of support for workflow corresponding to 'git add -p' has > been complained about frequently, it's one of the reasons people use Magit, > and I felt it as well many times. > > To improve your workflow, though, might it help to add a new command > 'diff-apply-buffer'? There is 'ediff-patch-buffer' that does this interactively like 'git add -p'.