From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Is it valid to call isearch-filter-predicate outside isearch? Date: Thu, 01 Jun 2023 09:38:11 +0300 Organization: LINKOV.NET Message-ID: <86o7lzaes4.fsf@mail.linkov.net> References: <875y8nks9t.fsf@localhost> <86pm6sb5g8.fsf@mail.linkov.net> <87ttvsn77s.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17808"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 01 08:40:12 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4byl-0004TJ-8a for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Jun 2023 08:40:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4byI-0003cB-SW; Thu, 01 Jun 2023 02:39:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4by2-0003I2-Hw for emacs-devel@gnu.org; Thu, 01 Jun 2023 02:39:26 -0400 Original-Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4bxz-0004ph-Ej for emacs-devel@gnu.org; Thu, 01 Jun 2023 02:39:26 -0400 X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 117EDFF809; Thu, 1 Jun 2023 06:39:18 +0000 (UTC) In-Reply-To: <87ttvsn77s.fsf@localhost> (Ihor Radchenko's message of "Wed, 31 May 2023 10:08:55 +0000") Received-SPF: pass client-ip=2001:4b98:dc4:8::229; envelope-from=juri@linkov.net; helo=relay9-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306482 Archived-At: > Org produces its own side effects to make isearch > support revealing text hidden via text properties. When your isearch-filter-predicate can't be improved to be usable also during query-replace, then probably you need to set isearch-filter-predicate in isearch-mode-hook, and remove afterwards in isearch-mode-end-hook. > I guess the answer to my question about `isearch-filter-predicate' is > yes - it may be called outside isearch and thus custom > `isearch-filter-predicate' must consider scenarios outside isearch. > > It would be nice if the docstring of `isearch-filter-predicate' > mentioned that it might be called outside isearch-mode. isearch.el is both a core library and UI with the search commands. UI commands for isearch-mode are enabled by C-s, etc. But as a core library its functions including isearch-filter-predicate are used by other packages such as replace.el.