unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: jm@pub.pink, emacs-devel@gnu.org
Subject: Re: master 5f9b5803bea: Fix zooming images in SHR
Date: Sun, 23 Jun 2024 22:23:44 +0300	[thread overview]
Message-ID: <86o77rcvjz.fsf@gnu.org> (raw)
In-Reply-To: <50938116-7ba6-5625-94e0-fb55dfdc449d@gmail.com> (message from Jim Porter on Sun, 23 Jun 2024 11:42:53 -0700)

> Date: Sun, 23 Jun 2024 11:42:53 -0700
> From: Jim Porter <jporterbugs@gmail.com>
> 
> On 6/23/2024 7:36 AM, john muhl wrote:
> > The zoom-image test added here fails on --without-x builds.
> 
> Thanks for noticing this. Fixed on the release branch with 6619aec6bca.

Thanks, but the test fails for me on MS-Windows:

  Test shr-test/zoom-image condition:
      Info: image with alt=nil
      (error "timed out waiting for condition")
     FAILED  3/4  shr-test/zoom-image (5.053704 sec) at lisp/net/shr-tests.el:136

(The other test failed as well, but I fixed it.)

Frankly, I have no idea why it fails, because I only vaguely
understand the idea of the test.  Feel free to ask questions or
suggests what to test.



  reply	other threads:[~2024-06-23 19:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <171912324641.7384.11296304660836747605@vcs2.savannah.gnu.org>
     [not found] ` <20240623061407.0C6DDC1FB5C@vcs2.savannah.gnu.org>
2024-06-23 14:36   ` master 5f9b5803bea: Fix zooming images in SHR john muhl
2024-06-23 18:42     ` Jim Porter
2024-06-23 19:23       ` Eli Zaretskii [this message]
2024-06-23 22:13         ` Jim Porter
2024-06-24 11:51           ` Eli Zaretskii
2024-06-26  5:09             ` Jim Porter
2024-06-26 13:49               ` Eli Zaretskii
2024-06-26 15:58                 ` Jim Porter
2024-06-26 16:04                   ` Eli Zaretskii
2024-06-28  3:51                     ` Jim Porter
2024-06-28 12:04                       ` Eli Zaretskii
2024-06-28 17:46                         ` Jim Porter
2024-06-29 11:09                           ` Eli Zaretskii
2024-06-29 22:00                             ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86o77rcvjz.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jm@pub.pink \
    --cc=jporterbugs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).