From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: pkg-autoloads.el vs. pkg-loaddefs.el Date: Wed, 14 Aug 2024 08:43:40 +0300 Message-ID: <86o75vfylv.fsf@gnu.org> References: <87y1adrria.fsf@localhost> <87o77zbs4j.fsf@localhost> <871q4us0l9.fsf@localhost> <87msniqhel.fsf@localhost> <87h6dqqaqp.fsf@localhost> <87h6dp9cde.fsf@localhost> <8734p8aomr.fsf@localhost> <86msngnr73.fsf@gnu.org> <87jzh5fwt5.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9796"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yantar92@posteo.net, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 14 07:44:43 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1se6oN-0002Pz-FL for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Aug 2024 07:44:43 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1se6nV-0004z2-S5; Wed, 14 Aug 2024 01:43:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1se6nU-0004yt-OB for emacs-devel@gnu.org; Wed, 14 Aug 2024 01:43:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1se6nQ-0003Rr-88; Wed, 14 Aug 2024 01:43:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=h99TwLlMjmn/zz7t0B78j2wlfe7C2ZeLF29ZKD9D/Ys=; b=K2ArGQzzB5LN PTqhd+vXVPZ25sHOYHyJup9ZS7+Ks/1U7qBpwrKV9dxJ7j7O/y5AVvYC2LQ4rK12uRFCgYoqD1rRx yDljuKHrsroliLage1Mz2Kse2fm7JK8PVApMWlznVZ73ORuklcE9FQrkOugCS6g9Yd4pny2/oG0cD dEBN60Zp6yp6NNlGZzLAe5TuLTVIfNWcBHTb1DEu3iVtV8xAHbJi7BkeVcebCZcDAMZxz+cD1VxYP 9crVormFZrzQuaU8OtLeeGtrp1w2vRoZjydw82fuAclr3K4sHpiWczFt9jjjChOepx6c0qaveGdSL rVCdMYrz6oq1RnxQFpCYrg==; In-Reply-To: (message from Stefan Monnier on Tue, 13 Aug 2024 20:31:45 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322730 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii , emacs-devel@gnu.org > Date: Tue, 13 Aug 2024 20:31:45 -0400 > > >>> -(defun package--reload-previously-loaded (pkg-desc) > >>> +(defun package--reload-previously-loaded (pkg-desc &optional warn) > >>> "Force reimportation of files in PKG-DESC already present in `load-history'. > >>> New editions of files contain macro definitions and > >>> redefinitions, the overlooking of which would cause > >>> -byte-compilation of the new package to fail." > >>> +byte-compilation of the new package to fail. > >>> +If WARN is a string, display a warning (using WARN as a format string) > >>> +before reloading the files." > >> > >> You say that WARN is treated as a format string, but that begs the > >> questions: what are the arguments to be formatted with that string? > > > > Stefan, do you have any comments? It seems to be the only blocker. > > It's an internal function, so I think the docstring is verbose > enough already. I agree, but since we've went to the trouble of having a doc string, why not add a few more words to clarify it?