From: Eli Zaretskii <eliz@gnu.org>
To: Pip Cet <pipcet@protonmail.com>
Cc: atamariya@gmail.com, emacs-devel@gnu.org
Subject: Re: bug#54188: Crash when eval-ing font test elisp code
Date: Wed, 28 Aug 2024 18:54:11 +0300 [thread overview]
Message-ID: <86o75chcd8.fsf@gnu.org> (raw)
In-Reply-To: <87frqozmww.fsf@protonmail.com> (message from Pip Cet on Wed, 28 Aug 2024 15:29:11 +0000)
> Date: Wed, 28 Aug 2024 15:29:11 +0000
> From: Pip Cet <pipcet@protonmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
>
> This code in fontset.c:
>
> /* If the parent face has no fontset we could work with, and has no
> font, just return that same face, so that the caller will
> consider the character to have no font capable of displaying it,
> and display it as "glyphless". That is certainly better than
> violating the assertion below or crashing when assertions are not
> compiled in. */
> if (face->fontset < 0 && !face->font)
> return face->id;
>
> would leave face->fontset at -1 and try to dereference it if face->font
> is non-NULL, and I don't understand why.
I didn't yet review the relevant code, but AFAIR face->fontset = -1
means the face has no fontset, and I think I saw in xfaces.c code
which handles that.
next prev parent reply other threads:[~2024-08-28 15:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 8:47 bug#54188: Crash when eval-ing font test elisp code Anand Tamariya
2024-08-28 12:37 ` Eli Zaretskii
2024-08-28 15:04 ` Anand Tamariya
2024-08-28 15:29 ` Pip Cet
2024-08-28 15:54 ` Eli Zaretskii [this message]
2024-08-28 18:07 ` Eli Zaretskii
2024-08-29 4:54 ` Anand Tamariya
2024-08-29 5:11 ` Yuri Khan
2024-08-29 6:02 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o75chcd8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=atamariya@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=pipcet@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).