From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Missing entries for Perl in etags-regen-file-extensions -- okay for emacs-30? Date: Fri, 20 Sep 2024 22:11:46 +0300 Message-ID: <86o74i5edp.fsf@gnu.org> References: <87y13mznw9.fsf@zephyr.silentflame.com> <86h6aa7gw1.fsf@gnu.org> <87ploya1hc.fsf@zephyr.silentflame.com> <867cb67888.fsf@gnu.org> <10dd3554-4249-41d1-864d-30cab687da6a@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27358"; mail-complaints-to="usenet@ciao.gmane.io" Cc: spwhitton@spwhitton.name, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 20 21:13:06 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1srj3y-0006yT-BA for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Sep 2024 21:13:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1srj2w-0004di-1z; Fri, 20 Sep 2024 15:12:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srj2t-0004dA-4g for emacs-devel@gnu.org; Fri, 20 Sep 2024 15:11:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srj2s-0002kL-9v; Fri, 20 Sep 2024 15:11:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7Vx0lX6/T+/5+XSbu6aZCxFpx1wPs6YeancKCLoHoS4=; b=ohS/Yd6zrWvF J46Fm3Vfb175GqtBf09tuJrN/0OP90eHRNyitFeuHDBTvH2WIZ6Rv3uTJ69W8YvligJ7CeWOi2/5T ecjyHxEupl8kQi2cnEDDwzSGKIR7zu8+P8H98JgPhVh/Bp4RqQ5JZsLLtSsSCCe6g8QpICk1unLQD K0rkPei0t1KFgAHdjMDvseON9YGpenBki05s6owh2JEZUlGC0coYqvvQc9CeiWz2PhNmJzWhv9eT3 4z8ECxVcgqbh9v2swtzlVichHlHr7Y8tWhVGg2eIGmUXr/XYuw6ucxdKnQc9qGfVpOSu32CLdcPnc oJpqJuTuDpRS3KUDN9yeFw==; In-Reply-To: <10dd3554-4249-41d1-864d-30cab687da6a@gutov.dev> (message from Dmitry Gutov on Fri, 20 Sep 2024 21:20:59 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323861 Archived-At: > Date: Fri, 20 Sep 2024 21:20:59 +0300 > Cc: emacs-devel@gnu.org > From: Dmitry Gutov > > >>> We already have "pl" in the list. Adding "pm" is okay, but then why > >>> only it? why not add all the extensions that 'etags' supports? > > Adding "pm" sounds good. > > "All supported extensions" (or most) might be a good idea as well. So I think we should add all of them on emacs-30. > As long as the additions are not misdetected often - false positives > based on obscure languages might be a nuisance. Agreed. But it sounds like the only such case is .m, which could be Mercury, not just ObjC. > >> Okay thanks, I'll add "pm" so we don't have just one Perl extension, and > >> hopefully we can figure out a better solution for master. > > My question about adding more extensions was for emacs-30. > > > > Let's wait for Dmitry to chime in, and take it from there. > > The reason why is that etags parses files with unknown extensions as > Fortran sources, and there is currently no opt-out. See this thread: > > https://lists.gnu.org/archive/html/emacs-devel/2018-01/msg00323.html > > The same issue stops us from benefiting from etags' hashbang detection. Right. These require to explicitly specify --language on the etags command line. So maybe etags-regen could learn to apply special command-line options to files matching a regexp. Or maybe we should add an option to etags to disable the fallback to Fortran.