From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback) Date: Mon, 23 Sep 2024 18:32:31 +0300 Message-ID: <86o74efks0.fsf@gnu.org> References: <87cyky43fb.fsf@ice9.digital> <86setu5f85.fsf@gnu.org> <87zfo22jy4.fsf@ice9.digital> <86bk0h5sx9.fsf@gnu.org> <87ldzlgxvh.fsf@ice9.digital> <87msk0oqoq.fsf@gnu.org> <87plovmmox.fsf@ice9.digital> <8734lqzx64.fsf@gnu.org> <864j66h9ey.fsf@gnu.org> <87tte6y3qt.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7431"; mail-complaints-to="usenet@ciao.gmane.io" Cc: morgan@ice9.digital, emacs-devel@gnu.org, visuweshm@gmail.com, manuel@ledu-giraud.fr To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 23 17:33:23 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ssl3y-0001fB-Rf for ged-emacs-devel@m.gmane-mx.org; Mon, 23 Sep 2024 17:33:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ssl3F-0007O1-DX; Mon, 23 Sep 2024 11:32:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssl3E-0007Nr-5x for emacs-devel@gnu.org; Mon, 23 Sep 2024 11:32:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssl3C-00033n-UD; Mon, 23 Sep 2024 11:32:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zfgn9nilHxYUrjjTeq7hg7IIP0qLCx1wQwgZDlf0eMw=; b=lUOUoDVJovyD xtw+Esmobvjn1r9ga69553nHR2jFR4HQUgBOWJxzDz63dMwCDSYQNWfSHnA7mj9h6uQaNP4u+8hfC wYaXdQQhp4SWFxrbR7UPUmWp5xJUGY9HcsK+yH96oJ/vEBH/76dLGkSsQpbsYqHMaznzqrbMZfd2M arzp1cF4VgJHS8FKqawLTFeHxP0ZOeAp30h7KbNfudTzF6DDxNFDXe4WTXZn6pex1+sw6dV5puduX kybFF5nB3MQE7yVjIOzzOv3IPeMoyXLsEtHHaq/lxml5SJZWfCIJleUeDH2GaC4eOEWkZsG6BEwEx XUOnNwh3v0HWG1gwz/MUIw==; In-Reply-To: <87tte6y3qt.fsf@gnu.org> (message from Tassilo Horn on Mon, 23 Sep 2024 14:05:30 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323967 Archived-At: > From: Tassilo Horn > Cc: morgan@ice9.digital, emacs-devel@gnu.org, visuweshm@gmail.com, Manuel > Giraud > Date: Mon, 23 Sep 2024 14:05:30 +0200 > > Eli Zaretskii writes: > > >> Eli, what do you think? > > > > Sorry, I don't understand what you are asking me about. Please > > elaborate > > > > It sounds like PDF documents with colors have inherent problems with > > doc-view-mupdf-use-svg and/or themes, so maybe we should warn about > > this in NEWS and in the doc string, and suggest that people either > > customize the doc-view-svg-face, or disable doc-view-mupdf-use-svg. > > Yes, exactly. There can be foreground-similar-to-background color > issues when mupdf + doc-view-mupdf-use-svg is used for certain, not > uncommon documents. > > We can either document that issue in NEWS and docstrings, or we can > simply set "black on white" as default value of doc-view-svg-face which > would eliminate those problems (and match what we had in emacs 29 before > the face was introduced by Manuel Giraud) but would stop trying to apply > our emacs theme to the document, too. > > I'd rather be conservative, use "black on white" as doc-view-svg-face > default value and document in NEWS and doc-view-svg-face's docstring > that one can style documents according to the emacs theme by inheriting > from the default face and not explicitly setting foreground and > background colors. Agreed.