Re: Adding git-commit highlight mode?

[Eli Zaretskii <eliz@gnu.org>]

> From: Sean Whitton <spwhitton@spwhitton.name>
> Date: Fri, 03 Jan 2025 21:02:21 +0000
> 
> Hello,
> 
> On Thu 02 Jan 2025 at 03:53pm -06, Stefan Kangas wrote:
> 
> > AFAICT, the 50 character line limit for the summary line is not really
> > followed very strictly in practice by most projects, including the Linux
> > kernel.  It's more of a recommendation.  Even the link you provide above
> > says that it's "a good idea" to use "no more than 50 characters" for it.
> > For that reason, I think that this should be a warning (with a highlight
> > if you go over), and not a hard limit.
> >
> > In `git-commit-mode`, the user option `git-commit-summary-max-length' is
> > 68 by default, which strikes me as unopinionated enough.
> 
> As Jonas mentioned, some of the things suggested in this thread overlap
> with our existing vc-git-log-edit-mode.  For example, we already have
> vc-git-log-edit-summary-target-len and vc-git-log-edit-summary-max-len.

vc-git-log-edit-mode kicks in only if one commits using VC commands.
It will not kick in if, for example, one commits from the shell prompt
with GIT_EDITOR set to invoke emacsclient.

So there's still a place for a mode that is turned on when Emacs needs
to edit the files with special names used by Git for some of the
activities.

> (As the VC maintainer, I would have appreciated being CC'd on this
> thread at some point; glad I caught it anyway.)

The thread was not about VC (still isn't, AFAICT), so it is not
surprising you were not CC'ed.