Add Ukrainian G to cyrillic-translit?

Add Ukrainian G to cyrillic-translit?

[Magnus Henoch]

I noticed that the input method cyrillic-translit doesn't contain the
Ukrainian letter "ghe with upturn", U+0490 and U+0491.

I propose the patch below, which adds "g'" and "G'" for this letter.
This would collide with the existing combination for "ordinary ghe" plus
"soft sign", but this combination never appears in Russian and Ukrainan,
at least.  Would there be any problem for other Cyrillic-using
languages?

Is this ok to commit to trunk and EMACS_22_BASE branch?

Magnus



diff --git a/leim/quail/cyrillic.el b/leim/quail/cyrillic.el
index 324d0d1..cac01f8 100644
*** a/leim/quail/cyrillic.el
--- b/leim/quail/cyrillic.el
***************
*** 1013,1019 ****
  Russian alphabet: a b v=w g d e yo=jo zh z i j=j' k l m n o p r s t
  u f h=kh=x c ch sh shch=sj=/s=/sht ~ y ' e\\ yu=ju ya=ja=q
  
! Also included are Ukrainian є (YE) = \"/e\" and ї (YI) = \"yi\",
  Belarusian ў (SHORT U) = \"u~\",
  Serbo-Croatian ђ (DJE) = \"/d\", ћ (CHJE)= \"/ch\",
  Macedonian ѓ (GJE) = \"/g\", ѕ (DZE) = \"/s\", ќ (KJE) = \"/k\",
--- 1013,1020 ----
  Russian alphabet: a b v=w g d e yo=jo zh z i j=j' k l m n o p r s t
  u f h=kh=x c ch sh shch=sj=/s=/sht ~ y ' e\\ yu=ju ya=ja=q
  
! Also included are Ukrainian є (YE) = \"/e\", ї (YI) = \"yi\",
! ґ (GHE WITH UPTURN) = \"g'\",
  Belarusian ў (SHORT U) = \"u~\",
  Serbo-Croatian ђ (DJE) = \"/d\", ћ (CHJE)= \"/ch\",
  Macedonian ѓ (GJE) = \"/g\", ѕ (DZE) = \"/s\", ќ (KJE) = \"/k\",
***************
*** 1055,1064 ****
--- 1056,1067 ----
   ("Ya" ?Я) ("YA" ?Я) ("Ja" ?Я) ("JA" ?Я) ("Q" ?Я)
  
   ("/e" ?є) ("yi" ?ї) ("u'" ?ў) ("u~" ?ў)
+  ("g'" ?ґ)
   ("/d" ?ђ) ("/ch" ?ћ)
   ("/g" ?ѓ) ("/s" ?ѕ) ("/k" ?ќ)
   ("/i" ?і) ("/j" ?ј) ("/l" ?љ) ("/n" ?њ) ("/z" ?џ)
   ("/E" ?Є) ("YE" ?Є) ("Yi" ?Ї) ("YI" ?Ї) ("U'" ?Ў) ("U~" ?Ў)
+  ("G'" ?Ґ)
   ("/D" ?Ђ) ("/Ch" ?Ћ) ("/CH" ?Ћ)
   ("/G" ?Ѓ) ("/S" ?Ѕ) ("/K" ?Ќ)
   ("/I" ?І) ("/J" ?Ј) ("/L" ?Љ) ("/N" ?Њ) ("/Z" ?Џ)

Re: Add Ukrainian G to cyrillic-translit?

[Ted Zlatanov]

On Wed, 10 Sep 2008 10:55:59 +0200 Magnus Henoch <mange@freemail.hu> wrote: 

MH> I noticed that the input method cyrillic-translit doesn't contain the
MH> Ukrainian letter "ghe with upturn", U+0490 and U+0491.

MH> I propose the patch below, which adds "g'" and "G'" for this letter.
MH> This would collide with the existing combination for "ordinary ghe" plus
MH> "soft sign", but this combination never appears in Russian and Ukrainan,
MH> at least.  Would there be any problem for other Cyrillic-using
MH> languages?

MH> Is this ok to commit to trunk and EMACS_22_BASE branch?

In trunk, cyrillic-translit has been modified quite a bit from the
EMACS_22_BASE version, so your patch is not accurate there.  Can you
take a look and compare, to be safe?  I looked and I think your patch
makes sense in both trunk and EMACS_22_BASE.  At least for Bulgarian it
would not be a problem, either (in addition to Russian and Ukrainian as
you mentioned).

Ted

Re: Add Ukrainian G to cyrillic-translit?

[Magnus Henoch]

Ted Zlatanov <tzz@lifelogs.com> writes:

> In trunk, cyrillic-translit has been modified quite a bit from the
> EMACS_22_BASE version, so your patch is not accurate there.  Can you
> take a look and compare, to be safe?

Oops, what I thought was the 22 version of cyrillic.el was actually
another copy of the trunk version...  The actual patch for the branch
would be the one below.

Magnus

--- cyrillic.el.~1.29.2.3.~	2008-07-02 13:43:45.000000000 +0200
+++ cyrillic.el	2008-09-10 20:19:54.000000000 +0200
@@ -1015,7 +1015,8 @@
 Russian alphabet: a b v=w g d e yo=jo zh z i j=j' k l m n o p r s t
 u f h=kh=x c ch sh shch=sj=/s=/sht ~ y ' e' yu=ju ya=ja=q
 
-Also included are Ukrainian є (YE) = \"/e\" and ї (YI) = \"yi\",
+Also included are Ukrainian є (YE) = \"/e\", ї (YI) = \"yi\",
+ґ (GHE WITH UPTURN) = \"g'\",
 Belarusian ў (SHORT U) = \"u'\",
 Serbo-Croatian ђ (DJE) = \"/d\", ћ (CHJE)= \"/ch\",
 Macedonian ѓ (GJE) = \"/g\", ѕ (DZE) = \"/s\", ќ (KJE) = \"/k\",
@@ -1056,10 +1057,12 @@
  ("Ya" ?Я) ("YA" ?Я) ("Ja" ?Я) ("JA" ?Я) ("Q" ?Я)
 
  ("/e" ?є) ("yi" ?ї) ("u'" ?ў)
+ ("g'" ?ґ)
  ("/d" ?ђ) ("/ch" ?ћ)
  ("/g" ?ѓ) ("/s" ?ѕ) ("/k" ?ќ)
  ("/i" ?і) ("/j" ?ј) ("/l" ?љ) ("/n" ?њ) ("/z" ?џ)
  ("/E" ?Є) ("YE" ?Є) ("Yi" ?Ї) ("YI" ?Ї) ("U'" ?Ў)
+ ("G'" ?Ґ)
  ("/D" ?Ђ) ("/Ch" ?Ћ) ("/CH" ?Ћ)
  ("/G" ?Ѓ) ("/S" ?Ѕ) ("/K" ?Ќ)
  ("/I" ?І) ("/J" ?Ј) ("/L" ?Љ) ("/N" ?Њ) ("/Z" ?Џ)

Re: Add Ukrainian G to cyrillic-translit?

[Ted Zlatanov]

On Wed, 10 Sep 2008 20:22:08 +0200 Magnus Henoch <mange@freemail.hu> wrote: 

MH> Ted Zlatanov <tzz@lifelogs.com> writes:
>> In trunk, cyrillic-translit has been modified quite a bit from the
>> EMACS_22_BASE version, so your patch is not accurate there.  Can you
>> take a look and compare, to be safe?

MH> Oops, what I thought was the 22 version of cyrillic.el was actually
MH> another copy of the trunk version...  The actual patch for the branch
MH> would be the one below.

Looks good to me as well.  Let the upturned Ukrainian G's free...

Ted

Re: Add Ukrainian G to cyrillic-translit?

[Magnus Henoch]

Ted Zlatanov <tzz@lifelogs.com> writes:

> Looks good to me as well.  Let the upturned Ukrainian G's free...

Committed to trunk and branch.

Magnus

Re: Add Ukrainian G to cyrillic-translit?

[Juri Linkov]

> I noticed that the input method cyrillic-translit doesn't contain the
> Ukrainian letter "ghe with upturn", U+0490 and U+0491.
>
> I propose the patch below, which adds "g'" and "G'" for this letter.
> This would collide with the existing combination for "ordinary ghe" plus
> "soft sign", but this combination never appears in Russian and Ukrainan,
> at least.  Would there be any problem for other Cyrillic-using
> languages?
>
> Is this ok to commit to trunk and EMACS_22_BASE branch?

Thanks, I see no problems with your patch.  As for the EMACS_22_BASE branch,
if there will be no another release from the 22 branch then there is
no sense in committing it to the branch.

-- 
Juri Linkov
http://www.jurta.org/emacs/