From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Preview: portable dumper Date: Tue, 20 Feb 2018 00:54:29 +0000 Message-ID: <86mv04qy4a.fsf@gmail.com> References: <047a67ec-9e29-7e4e-0fb0-24c3e59b5886@dancol.org> <83zikjxt1j.fsf@gnu.org> <8360n6ruzu.fsf@gnu.org> <834m2nplmb.fsf@gnu.org> <83inr2oje6.fsf@gnu.org> <83bmwuogfb.fsf@gnu.org> <878trydrbo.fsf@red-bean.com> <87d15jo39q.fsf@ritchie.wxcvbn.org> <26497701-9de7-b91e-7ac3-4fb5949b436e@dancol.org> <83po58yhew.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1519087997 18086 195.159.176.226 (20 Feb 2018 00:53:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Feb 2018 00:53:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 20 01:53:13 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1enwB6-0003pt-At for ged-emacs-devel@m.gmane.org; Tue, 20 Feb 2018 01:53:04 +0100 Original-Received: from localhost ([::1]:53000 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1enwD8-0008Ch-Lm for ged-emacs-devel@m.gmane.org; Mon, 19 Feb 2018 19:55:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1enwD1-0008CD-W2 for emacs-devel@gnu.org; Mon, 19 Feb 2018 19:55:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1enwCx-00034l-Vj for emacs-devel@gnu.org; Mon, 19 Feb 2018 19:55:04 -0500 Original-Received: from [195.159.176.226] (port=52237 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1enwCx-00034X-Od for emacs-devel@gnu.org; Mon, 19 Feb 2018 19:54:59 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1enwAo-0002gK-5s for emacs-devel@gnu.org; Tue, 20 Feb 2018 01:52:46 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 35 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:v+/yEM9KTfN5ejJ05tFEg57EXx8= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223489 On Tue 13 Feb 2018, Eli Zaretskii wrote: >> From: Daniel Colascione >> Date: Mon, 12 Feb 2018 12:18:36 -0800 >> >> I've pushed the portable dumper to the pdumper Savannah branch. It >> should support a fully PIC Emacs. > > Thanks. I'd urge people to try this branch and report any issues they > see. The branch currently fails for out of tree builds (tested with mingw64 on msys2 for 64bit Windows). Something like this is needed to fix it: diff --git a/src/Makefile.in b/src/Makefile.in index e2950a02eb..0df59b90a8 100644 --- a/src/Makefile.in +++ b/src/Makefile.in @@ -411,11 +411,13 @@ base_obj = $(W32_OBJ) $(WINDOW_SYSTEM_OBJ) $(XGSELOBJ) $(JSON_OBJ) obj = $(base_obj) $(NS_OBJC_OBJ) -dmpstruct_headers=lisp.h buffer.h intervals.h charset.h +dmpstruct_headers = ${srcdir}/lisp.h ${srcdir}/buffer.h ${srcdir}/intervals.h \ + ${srcdir}/charset.h pdumper.o: dmpstruct.h -dmpstruct.h: dmpstruct.awk +dmpstruct.h: ${srcdir}/dmpstruct.awk dmpstruct.h: $(libsrc)/make-fingerprint$(EXEEXT) $(dmpstruct_headers) - POSIXLY_CORRECT=1 awk -f dmpstruct.awk $(dmpstruct_headers) > $@ + POSIXLY_CORRECT=1 awk -f ${srcdir}/dmpstruct.awk \ + $(dmpstruct_headers) > $@ ## Object files used on some machine or other. ## These go in the DOC file on all machines in case they are needed.