From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [Patch] Add project.el command to replace symbol at point throughout project Date: Wed, 02 Feb 2022 21:51:23 +0200 Organization: LINKOV.NET Message-ID: <86mtj9xd1g.fsf@mail.linkov.net> References: <83zgo2770l.fsf@gnu.org> <83zgo15dhp.fsf@gnu.org> <83czkw3uvl.fsf@gnu.org> <170a1c89-7767-0930-f726-f7b2551876b2@yandex.ru> <44f72f97-d1d8-0b4c-73a0-7f077fb1ef26@yandex.ru> <0617E8BF-CC43-4D82-8648-064252F644FD@gmail.com> <86pmos3no7.fsf@mail.linkov.net> <86czkr36ll.fsf@mail.linkov.net> <921c0b69-7bac-b78a-54d8-987165331661@yandex.ru> <0b8d87f8-e6db-9902-bd89-d81864d626d6@yandex.ru> <861r16235x.fsf@mail.linkov.net> <829a1d78-c07e-4bb8-e3bd-07263271fc30@yandex.ru> <86sft3kbja.fsf@mail.linkov.net> <35a7ae0c-7d9f-4feb-be3b-a93ad4f7a795@yandex.ru> <86a6famjr8.fsf@mail.linkov.net> <9915e49c-81c9-5a8e-2aa9-a223740231dd@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3274"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Jon Eskin , Eli Zaretskii , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 02 21:32:52 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFMJ9-0000iB-Or for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Feb 2022 21:32:51 +0100 Original-Received: from localhost ([::1]:41398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nFMJ8-0007M8-Ol for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Feb 2022 15:32:50 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFLhJ-0003p6-BI for emacs-devel@gnu.org; Wed, 02 Feb 2022 14:53:45 -0500 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:53491) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFLhF-0002S9-4I; Wed, 02 Feb 2022 14:53:45 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id BC77B200005; Wed, 2 Feb 2022 19:53:35 +0000 (UTC) In-Reply-To: <9915e49c-81c9-5a8e-2aa9-a223740231dd@yandex.ru> (Dmitry Gutov's message of "Wed, 2 Feb 2022 00:07:46 +0200") Received-SPF: pass client-ip=217.70.178.232; envelope-from=juri@linkov.net; helo=relay12.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285804 Archived-At: > On 01.02.2022 22:09, Juri Linkov wrote: >>>> After thinking more about this, I can't find a possible use for >>>> read-string-defaults-function, because every call of read-string >>>> provides own default value. Also using read-regexp-defaults-function >>>> in query-replace-read-from is not the right thing either - when >>>> the users already customized it for e.g. occur, it would be too >>>> unexpected when it will use a tag at point instead of from->to >>>> pairs in query-replace. >>>> Since query-replace is a very special command, the most uncontroversial >>>> thing to do for a conservative approach would be to add two specific >>>> variables (that later could be turned into options when needed): >>> Sounds reasonable, thanks. >>> >>> If you're satisfied with the change, please go ahead and install the >>> patches. >> So now patches are installed in master. > > Thanks! > > Could you try testing the new behavior in xref-find-references-and-replace? Sorry, I tested everything in the previous version of the patch, but then forgot that read-string is different from read-from-minibuffer. > I'm seeing this: > > - If there are no entries in history, I see the appropriate text in the > first prompt (featuring the tag near point), but when I press RET, the > next prompt which should mention the thing to replace, just has two > spaces in a row. And indeed, the behavior is as if it's read an empty > string. > > - If there are history entries, and I press RET (to use the default FROM), > it proceeds to do a search right away instead of prompting me for TO. And > it uses the from-to pair from history instead of the current input. Now everything is fixed (at least in all tested cases).