From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Flymake Support Indicator Errors in Margin Date: Thu, 14 Mar 2024 13:05:33 +0200 Message-ID: <86msr19ipu.fsf@gnu.org> References: <87r0gfajlh.fsf@posteo.net> <868r2mtjdk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33489"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, emacs-devel@gnu.org To: Elijah G , =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 14 12:06:51 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rkivC-0008U4-67 for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Mar 2024 12:06:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rkiuI-0001o3-LH; Thu, 14 Mar 2024 07:05:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkiuF-0001nh-Bg for emacs-devel@gnu.org; Thu, 14 Mar 2024 07:05:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkiuB-0000s7-S3; Thu, 14 Mar 2024 07:05:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=8mKXFLLEiuxEel1Dx6kGaLcmsBadaQfMjmfx8v+Uzh4=; b=VViZkO5os5VuHyiBIuKX fQgw1cNE4Op13srwsQxGEZ7WWjPSVJ/yvPJTk7dLj7x2XdzPk3qxi0W81my3t7JeZScPAiSJQeNnj UkV8CJlMfgJ4w7YJAGsozaycyDkYpbP1Zb5f6uRQpP4h4ukSmWyvPpSOTiXzCoQct4t6XqQKaIL7K eJmy3MhOkn5WlBc0K807OT2kMNSEKbHdfTGdtG+cCTwli1ZmhEndNzQN9Ra9dEW+0cU7XdFnaF2wz EBoPsU3xKY1Zo/DOAyjgPiAnjSeV+pgviHB/E0wwv8VcXTmQaSpNt3o627JheyOUhrXX75+pIxPdR n7P+i6ejBGbFcw==; In-Reply-To: (message from Elijah G on Wed, 13 Mar 2024 19:50:59 -0600) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317043 Archived-At: > From: Elijah G > Date: Wed, 13 Mar 2024 19:50:59 -0600 > Cc: philipk@posteo.net, emacs-devel@gnu.org > > I think this is a mistake: it makes this change backward-incompatible, > in the sense that users who had customizations of the options you are > removing will now have to rework their customizations. We try to > avoid backward-incompatible changes like this as much as possible. It > doesn't sound to me like this part of the patch is strictly needed, is > it? > > > You are right, i was planning something like marking those variables as deprecated for 30, > but since it makes backward incompatible think it can be too early to do it in this patch, > However I find merging them easier to customize instead of defining them separately. > > If these variables are necessary, I've now reverted the changes in the patch. Thanks. > +(defcustom flymake-margin-indicators-string > + `((error ,(if (char-displayable-p 8252) > + "‼" > + "!!") > + compilation-error) When do you expect this value to be evaluated? In general, I wonder whether it would be simpler and wiser to use just "!!", and leave it to users to customize to "‼" if their displays support that. (We can mention the possibility in the doc string.) João, any comments?