From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 431f8ff1e38: * lisp/imenu.el: Support more values for imenu-flatten (bug#70846) Date: Fri, 17 May 2024 19:43:12 +0300 Organization: LINKOV.NET Message-ID: <86msoo4cf3.fsf@mail.linkov.net> References: <171558357066.26019.9766615061719600757@vcs2.savannah.gnu.org> <20240513065931.0D83AC12C31@vcs2.savannah.gnu.org> <86v83hwxjs.fsf@mail.linkov.net> <86ikzhq6ja.fsf@mail.linkov.net> <86o798x5hz.fsf@gnu.org> <86bk572e6a.fsf@mail.linkov.net> <861q62pb8y.fsf@mail.linkov.net> <864jayjd8u.fsf@gnu.org> <86le49ymsl.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20372"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , me@eshelyaron.com, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 17 18:50:24 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s80mm-0005A2-1c for ged-emacs-devel@m.gmane-mx.org; Fri, 17 May 2024 18:50:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s80lq-0007CM-Gx; Fri, 17 May 2024 12:49:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s80lm-0007Bd-AV for emacs-devel@gnu.org; Fri, 17 May 2024 12:49:23 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s80lk-0000ar-4y; Fri, 17 May 2024 12:49:22 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 5123F20004; Fri, 17 May 2024 16:49:14 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Fri, 17 May 2024 11:36:22 -0400") X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=217.70.183.200; envelope-from=juri@linkov.net; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319328 Archived-At: >> But there is another separate problem: Eshel asked to replace >> let-bindings around completing-read with the minibuffer-local value >> of minibuffer-allow-text-properties. However, this is impossible to do >> because read-from-minibuffer called from completing-read can't use >> a minibuffer-local value of minibuffer-allow-text-properties. > > It could use something like `minibuffer-with-setup-hook`, no? > This might be a good opportunity to allow the INIT argument to be > a function (run within the fresh new minibuffer). I see no way of doing that, this doesn't work: (minibuffer-with-setup-hook (lambda () (setq-local minibuffer-allow-text-properties t)) (completing-read "Prompt: " (list (propertize "foo1" 'prop t) (propertize "foo2" 'prop t)))) because when `completing-read-default` calls `read-from-minibuffer`, it uses the value of `minibuffer-allow-text-properties` from the original buffer: val = read_minibuf (keymap, initial_contents, prompt, !NILP (read), histvar, histpos, default_value, minibuffer_allow_text_properties, !NILP (inherit_input_method)); Then `read_minibuf` uses its argument `allow_props`: if (allow_props) val = Fminibuffer_contents (); else val = Fminibuffer_contents_no_properties (); Maybe it could use `minibuffer-allow-text-properties` directly here?