unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master f3891da4972 1/2: ; * src/w32image.c (thumb_type_data): Revert parts of recent change.
Date: Fri, 31 May 2024 16:12:43 +0300	[thread overview]
Message-ID: <86mso6p1kk.fsf@gnu.org> (raw)
In-Reply-To: <87wmna8bw1.fsf@yahoo.com> (message from Po Lu on Fri, 31 May 2024 19:21:50 +0800)

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Fri, 31 May 2024 19:21:50 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > We don't adhere to that part of the coding standards, and I see no
> > reason why we should start now.
> 
> When was this decision made?

Long ago.  Just look at the sources.

> > (The original reason, now lost to history, was that CC Mode produced
> > better indentation that way.)
> 
> Wasn't that the indentation that is nowadays only applied to `enum's,
> i.e.,
> 
> struct foo
>   {
>     int x, y;
>   };

I'm not sure I understand what you are saying, but standards.texi says
to use the same format for struct's and enum's.

Also, neither CC Mode nor c-ts-mode produce a 2-space offset before
braces in a struct that is declared at top level.



      reply	other threads:[~2024-05-31 13:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <171713741024.17516.6154639966246811985@vcs2.savannah.gnu.org>
     [not found] ` <20240531063650.CB52AC5400C@vcs2.savannah.gnu.org>
2024-05-31  7:55   ` master f3891da4972 1/2: ; * src/w32image.c (thumb_type_data): Revert parts of recent change Po Lu
2024-05-31 10:36     ` Eli Zaretskii
2024-05-31 11:21       ` Po Lu
2024-05-31 13:12         ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86mso6p1kk.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).